All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Krefting <peter@softwolves.pp.se>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Add script for importing bits-and-pieces to Git.
Date: Tue, 25 Aug 2009 19:59:36 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.00.0908251953480.19406@ds9.cixit.se> (raw)
In-Reply-To: <7vy6p9do4k.fsf@alter.siamese.dyndns.org>

Junio C Hamano:

> Nice write-up.

Thank you.

As to your questions, they are very good, and I'll try to update the 
documentation a bit to clarify the points you made. This is the first time 
someone who is not myself have read it, so I expected some rough edges...

Follow-ups on some of the points (I will address the rest as well):

> You might want to mention that this format is different from what git uses 
> for its .git/config and .gitmodules files, and none of the rules apply to 
> them (namely, two/three-level names, case sensitivity, allowed letters in 
> variable names, stripping of whitespaces around values, and value quoting) 
> described in 'git help config' apply to this file.

A quick question on that: Is it possible to use the git-config parser 
stand-alone from a script like this? Then that note wouldn't need to apply.

> As you seem to be supporting merges, you might want to say topologically 
> instead of chronologically---this is minor, as you give more precise 
> definition "all parents must come before a child" in that sentence later.

I'm not sure I get the distinction here. Could you be a bit more specific 
(or point me to what I have missed in the Git manual)?

> How are problematic characters in pathnames (say, SP, '=' or worse LF)
> handled?  Do they need to be quoted, and if so how?

In the current version: Not at all. :-) I didn't need to, at the time.

-- 
\\// Peter - http://www.softwolves.pp.se/

  reply	other threads:[~2009-08-25 19:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-24 17:09 [PATCH v2] Add script for importing bits-and-pieces to Git Peter Krefting
2009-08-24 19:10 ` Junio C Hamano
2009-08-25 18:59   ` Peter Krefting [this message]
2009-08-25 20:42     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0908251953480.19406@ds9.cixit.se \
    --to=peter@softwolves.pp.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.