From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757073Ab0BKVoM (ORCPT ); Thu, 11 Feb 2010 16:44:12 -0500 Received: from smtp-out.google.com ([216.239.33.17]:46732 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756920Ab0BKVoK (ORCPT ); Thu, 11 Feb 2010 16:44:10 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=aVI3XuPFIKyNIpGlcF2T1FQPtPysbLJEZ5is+TKP3v2c8YiWh3bTs8kLtseYXqnYs EMWwhDeLDtUN4RpihjHkg== Date: Thu, 11 Feb 2010 13:44:05 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andi Kleen cc: penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org, linux-mm@kvack.org, haicheng.li@intel.com Subject: Re: [PATCH] [2/4] SLAB: Separate node initialization into separate function In-Reply-To: <20100211205402.02E7EB1978@basil.firstfloor.org> Message-ID: References: <20100211953.850854588@firstfloor.org> <20100211205402.02E7EB1978@basil.firstfloor.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2010, Andi Kleen wrote: > Index: linux-2.6.32-memhotadd/mm/slab.c > =================================================================== > --- linux-2.6.32-memhotadd.orig/mm/slab.c > +++ linux-2.6.32-memhotadd/mm/slab.c > @@ -1158,19 +1158,9 @@ free_array_cache: > } > } > > -static int __cpuinit cpuup_prepare(long cpu) > +static int slab_node_prepare(int node) I still think this deserves a comment saying that slab_node_prepare() requires cache_chain_mutex, I'm not sure people interested in node hotadd would be concerned with whether the implementation needs to iterate slab caches or not. Otherwise: Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 546386B0078 for ; Thu, 11 Feb 2010 16:44:11 -0500 (EST) Received: from kpbe20.cbf.corp.google.com (kpbe20.cbf.corp.google.com [172.25.105.84]) by smtp-out.google.com with ESMTP id o1BLi8h9021124 for ; Thu, 11 Feb 2010 13:44:08 -0800 Received: from pzk1 (pzk1.prod.google.com [10.243.19.129]) by kpbe20.cbf.corp.google.com with ESMTP id o1BLhQag006693 for ; Thu, 11 Feb 2010 13:44:07 -0800 Received: by pzk1 with SMTP id 1so253567pzk.16 for ; Thu, 11 Feb 2010 13:44:07 -0800 (PST) Date: Thu, 11 Feb 2010 13:44:05 -0800 (PST) From: David Rientjes Subject: Re: [PATCH] [2/4] SLAB: Separate node initialization into separate function In-Reply-To: <20100211205402.02E7EB1978@basil.firstfloor.org> Message-ID: References: <20100211953.850854588@firstfloor.org> <20100211205402.02E7EB1978@basil.firstfloor.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org, linux-mm@kvack.org, haicheng.li@intel.com List-ID: On Thu, 11 Feb 2010, Andi Kleen wrote: > Index: linux-2.6.32-memhotadd/mm/slab.c > =================================================================== > --- linux-2.6.32-memhotadd.orig/mm/slab.c > +++ linux-2.6.32-memhotadd/mm/slab.c > @@ -1158,19 +1158,9 @@ free_array_cache: > } > } > > -static int __cpuinit cpuup_prepare(long cpu) > +static int slab_node_prepare(int node) I still think this deserves a comment saying that slab_node_prepare() requires cache_chain_mutex, I'm not sure people interested in node hotadd would be concerned with whether the implementation needs to iterate slab caches or not. Otherwise: Acked-by: David Rientjes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org