All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: "Agarwal, Preshit" <preshit.agarwal@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Pais, Allen" <allen.pais@ti.com>
Subject: Re: [PATCH v3 1/1] Registering sgx device and it's platform data
Date: Wed, 31 Mar 2010 03:39:39 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1003310330470.14436@utopia.booyaka.com> (raw)
In-Reply-To: <20100330094902.GG30597@nokia.com>

Hi Felipe,

On Tue, 30 Mar 2010, Felipe Balbi wrote:

> On Tue, Mar 30, 2010 at 10:49:19AM +0200, ext Paul Walmsley wrote:
> > I would suggest that you name this function be named something more
> > specific, such as omap_sgx_set_bus_tput(), since the SGX driver may also
> > need to set other PM constraints later, such as wakeup latency
> > constraints.
> 
> then it could just add the contraints to the same function instead of passing
> another pointer to driver ??

It's hard to say without looking at the driver.  

Bus throughput constraints are only needed when the device is actively 
transferring data to/from the rest of the system.

Wakeup latency constraints are only needed when the device can go idle and 
enter some low-power state, but also needs to be ready in some limited 
amount of time to service an interrupt or a wakeup.

So, often it would make sense to set the two parameters at different 
points in the driver code.


- Paul

      reply	other threads:[~2010-03-31  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30  7:06 [PATCH v3 1/1] Registering sgx device and it's platform data Agarwal, Preshit
2010-03-30  8:45 ` Felipe Balbi
2010-03-30  8:49 ` Paul Walmsley
2010-03-30  9:49   ` Felipe Balbi
2010-03-31  9:39     ` Paul Walmsley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1003310330470.14436@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=allen.pais@ti.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=preshit.agarwal@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.