From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757276Ab0F3UHl (ORCPT ); Wed, 30 Jun 2010 16:07:41 -0400 Received: from smtp-out.google.com ([74.125.121.35]:21674 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756210Ab0F3UHU (ORCPT ); Wed, 30 Jun 2010 16:07:20 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=TXimUIh+JhilarsOI0Kz1O1X5VmZk0Dwhnziuosf5dDEq8owW6Vgigv89JteDvjy9 oimTMxQ2iXVuACkYUdFgg== Date: Wed, 30 Jun 2010 13:07:12 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Xiaotian Feng cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , Matt Mackall , Vegard Nossum , Dmitry Monakhov , Catalin Marinas Subject: Re: [PATCH V2] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING In-Reply-To: <1277891842-18898-1-git-send-email-dfeng@redhat.com> Message-ID: References: <1277891842-18898-1-git-send-email-dfeng@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jun 2010, Xiaotian Feng wrote: > In slab, all __xxx_track_caller is defined on CONFIG_DEBUG_SLAB || CONFIG_TRACING, > thus caller tracking function should be worked for CONFIG_TRACING. But if > CONFIG_DEBUG_SLAB is not set, include/linux/slab.h will define xxx_track_caller to > __xxx() without consideration of CONFIG_TRACING. This will break the caller tracking > behaviour then. > > Signed-off-by: Xiaotian Feng > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: Matt Mackall > Cc: Vegard Nossum > Cc: Dmitry Monakhov > Cc: Catalin Marinas > Cc: David Rientjes Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 7D6F56B01AF for ; Wed, 30 Jun 2010 16:07:22 -0400 (EDT) Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id o5UK7Ie4021528 for ; Wed, 30 Jun 2010 13:07:18 -0700 Received: from pva18 (pva18.prod.google.com [10.241.209.18]) by hpaq14.eem.corp.google.com with ESMTP id o5UK7Grw000441 for ; Wed, 30 Jun 2010 13:07:17 -0700 Received: by pva18 with SMTP id 18so491050pva.32 for ; Wed, 30 Jun 2010 13:07:16 -0700 (PDT) Date: Wed, 30 Jun 2010 13:07:12 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH V2] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING In-Reply-To: <1277891842-18898-1-git-send-email-dfeng@redhat.com> Message-ID: References: <1277891842-18898-1-git-send-email-dfeng@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Xiaotian Feng Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , Matt Mackall , Vegard Nossum , Dmitry Monakhov , Catalin Marinas List-ID: On Wed, 30 Jun 2010, Xiaotian Feng wrote: > In slab, all __xxx_track_caller is defined on CONFIG_DEBUG_SLAB || CONFIG_TRACING, > thus caller tracking function should be worked for CONFIG_TRACING. But if > CONFIG_DEBUG_SLAB is not set, include/linux/slab.h will define xxx_track_caller to > __xxx() without consideration of CONFIG_TRACING. This will break the caller tracking > behaviour then. > > Signed-off-by: Xiaotian Feng > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: Matt Mackall > Cc: Vegard Nossum > Cc: Dmitry Monakhov > Cc: Catalin Marinas > Cc: David Rientjes Acked-by: David Rientjes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org