From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37883 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oju1A-0004g6-Tm
	for qemu-devel@nongnu.org; Fri, 13 Aug 2010 09:09:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1Oju19-0006FV-5A
	for qemu-devel@nongnu.org; Fri, 13 Aug 2010 09:09:52 -0400
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:3447
	helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1Oju18-0006FL-VP
	for qemu-devel@nongnu.org; Fri, 13 Aug 2010 09:09:51 -0400
Date: Fri, 13 Aug 2010 14:10:01 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 12/15] piix_pci: introduce a write_config
	notifier
In-Reply-To: <AANLkTim+=eUq+kfccJ11KFvTWcDL=nPawc42H0qyyi88@mail.gmail.com>
Message-ID: <alpine.DEB.2.00.1008130151490.2545@kaball-desktop>
References: <alpine.DEB.2.00.1008121244200.2545@kaball-desktop>
	<1281622202-3453-12-git-send-email-stefano.stabellini@eu.citrix.com>
	<AANLkTim+=eUq+kfccJ11KFvTWcDL=nPawc42H0qyyi88@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-ID: <alpine.DEB.2.00.1008131326561.2545@kaball-desktop>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>

On Thu, 12 Aug 2010, Blue Swirl wrote:
> On Thu, Aug 12, 2010 at 2:09 PM,  <stefano.stabellini@eu.citrix.com> wrote:
> > From: Anthony PERARD <anthony.perard@citrix.com>
> >
> > Introduce a write config notifier in piix_pci, so that clients can be
> > notified every time a pci config write happens.
> > The patch also makes use of the notification mechanism in
> > xen_machine_fv.
> 
> Will the mechanism be used elsewhere? If not, I'd just add a call to
> xen_piix_pci_write_config_client() to piix_pci.c. It can be surrounded
> by Xen #ifdeffery, or you could introduce stubs like kvm-stub.c and
> friends.
> 

we were trying to avoid ifdef's in piix_pci, but if you are OK with just a
couple of them we'll gladly remove the hook.