From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37978 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oju1Z-0004sB-RH for qemu-devel@nongnu.org; Fri, 13 Aug 2010 09:10:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oju1X-0006Ku-5T for qemu-devel@nongnu.org; Fri, 13 Aug 2010 09:10:16 -0400 Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:30349 helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oju1W-0006Ki-Si for qemu-devel@nongnu.org; Fri, 13 Aug 2010 09:10:15 -0400 Date: Fri, 13 Aug 2010 14:10:25 +0100 From: Stefano Stabellini Subject: Re: [Qemu-devel] [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen In-Reply-To: Message-ID: References: <1281622202-3453-15-git-send-email-stefano.stabellini@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Anthony Perard , "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" , Stefano Stabellini On Thu, 12 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 2:10 PM, wrote: > > From: Anthony PERARD > > > > Xen currently uses a different BIOS (hvmloader + rombios) therefore the > > Qemu acpi_piix4 implementation wouldn't work correctly with Xen. > > We plan on fixing this properly but at the moment we are just adding a > > new Xen specific acpi_piix4 implementation. > > I'd suppose the proper fix is to modify acpi_piix4 instead of copy&paste. > Yes, but we would need few xen specific hooks in acpi_piix4 to make the S state transitions work correctly; if you are OK with it we'll proceed in that direction. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen Date: Fri, 13 Aug 2010 14:10:25 +0100 Message-ID: References: <1281622202-3453-15-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Blue Swirl Cc: Anthony Perard , "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, 12 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 2:10 PM, wrote: > > From: Anthony PERARD > > > > Xen currently uses a different BIOS (hvmloader + rombios) therefore the > > Qemu acpi_piix4 implementation wouldn't work correctly with Xen. > > We plan on fixing this properly but at the moment we are just adding a > > new Xen specific acpi_piix4 implementation. > > I'd suppose the proper fix is to modify acpi_piix4 instead of copy&paste. > Yes, but we would need few xen specific hooks in acpi_piix4 to make the S state transitions work correctly; if you are OK with it we'll proceed in that direction.