From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754051Ab0HWRRg (ORCPT ); Mon, 23 Aug 2010 13:17:36 -0400 Received: from smtp102.prem.mail.ac4.yahoo.com ([76.13.13.41]:39779 "HELO smtp102.prem.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753947Ab0HWRRf (ORCPT ); Mon, 23 Aug 2010 13:17:35 -0400 X-Yahoo-SMTP: _Dag8S.swBC1p4FJKLCXbs8NQzyse1SYSgnAbY0- X-YMail-OSG: b1XOl1sVM1no7kB02y1BENdMjRqds8OoW7ioGjoYMx69YR. xcjyGshYNIIEzmmB3YgSxlsvLEIIojG6KhjFdZ1DoIwEdHNmuB8tn7_wDWdm P0U.bO8T0XXmUePcKRelMyXRTNWieWRgJTrHARuTiusFvvSgBc7AlmbyrZl0 lKIYH3tl1hQfUL8UBcP3tVD_WyVgGp9ybcvixwYHLZyKQhR057w4gjDxU8H1 u X-Yahoo-Newman-Property: ymail-3 Date: Mon, 23 Aug 2010 12:17:31 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Minchan Kim cc: Andrew Morton , Linux Kernel List , linux-mm@kvack.org, Hugh Dickins , Andi Kleen , Mel Gorman Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting In-Reply-To: <20100823170610.GB2304@barrios-desktop> Message-ID: References: <1282580114-2136-1-git-send-email-minchan.kim@gmail.com> <20100823170610.GB2304@barrios-desktop> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Aug 2010, Minchan Kim wrote: > On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote: > > On Tue, 24 Aug 2010, Minchan Kim wrote > > > > > This patch introude new argument 'cleanup' to migrate_pages. > > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists. > > > Otherwise, caller need to clean up the lists so it has a chance to postprocess > > > the pages. > > > > Could we simply make migrate_pages simply not do any cleanup? > > Caller has to call putback_lru_pages()? > > > Hmm. maybe I misunderstood your point. > Your point is that let's make whole caller of migrate_pagse has a responsibility > of clean up the list? Yes. All callers would be responsible for cleanup. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 05BFE6007EE for ; Mon, 23 Aug 2010 13:19:12 -0400 (EDT) Date: Mon, 23 Aug 2010 12:17:31 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting In-Reply-To: <20100823170610.GB2304@barrios-desktop> Message-ID: References: <1282580114-2136-1-git-send-email-minchan.kim@gmail.com> <20100823170610.GB2304@barrios-desktop> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Andrew Morton , Linux Kernel List , linux-mm@kvack.org, Hugh Dickins , Andi Kleen , Mel Gorman List-ID: On Tue, 24 Aug 2010, Minchan Kim wrote: > On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote: > > On Tue, 24 Aug 2010, Minchan Kim wrote > > > > > This patch introude new argument 'cleanup' to migrate_pages. > > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists. > > > Otherwise, caller need to clean up the lists so it has a chance to postprocess > > > the pages. > > > > Could we simply make migrate_pages simply not do any cleanup? > > Caller has to call putback_lru_pages()? > > > Hmm. maybe I misunderstood your point. > Your point is that let's make whole caller of migrate_pagse has a responsibility > of clean up the list? Yes. All callers would be responsible for cleanup. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org