From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values)
Date: Fri, 28 Jan 2011 13:27:11 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1101281326510.7277@kaball-desktop> (raw)
In-Reply-To: <19778.46683.733579.390062@mariner.uk.xensource.com>
On Fri, 28 Jan 2011, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values)"):
> > On Thu, 27 Jan 2011, Ian Jackson wrote:
> > > int libxl__domain_make(libxl_ctx *ctx, libxl_domain_create_info *info,
> > > - uint32_t *domid)
> > > + uint32_t *domid /* domid 0 or ~0 on entry; on exit
> > > + valid, perhaps >0 (even on error) */)
> >
> > can you please change this comment too?
>
> What do you think would be clearer ? -1 isn't right since a
> uint32_t can't have the value -1.
>
domid 0 or domid > DOMID_FIRST_RESERVED on entry
next prev parent reply other threads:[~2011-01-28 13:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 17:40 [PATCH 0/6] libxl, xl: fix domain name uniqueness check Ian Jackson
2011-01-27 17:40 ` [PATCH 1/6] xl: Revert "xl: avoid creating domains with duplicate names" Ian Jackson
2011-01-27 17:41 ` [PATCH 2/6] libxl: fix error handling (xenstore transaction leak) in libxl__domain_make Ian Jackson
2011-01-27 17:41 ` [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values) Ian Jackson
2011-01-27 17:41 ` [PATCH 4/6] libxl: internals: document the error behaviour of various libxl__xs_* functions Ian Jackson
2011-01-27 17:41 ` [PATCH 5/6] libxl: during domain destruction, do not complain if no devices dir to destroy Ian Jackson
2011-01-27 17:41 ` [PATCH 6/6] libxl: prevent creation of domains with duplicate names Ian Jackson
2011-01-27 18:33 ` [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values) Stefano Stabellini
2011-01-27 18:59 ` Ian Jackson
2011-01-27 20:01 ` Ian Jackson
2011-01-27 20:13 ` Gianni Tedesco
2011-01-28 12:22 ` Stefano Stabellini
2011-01-28 12:28 ` Ian Jackson
2011-01-28 13:27 ` Stefano Stabellini [this message]
2011-01-28 17:38 ` Ian Jackson
2011-01-28 17:52 ` Stefano Stabellini
2011-01-28 18:39 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1101281326510.7277@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.