From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 6/6] libxl: vncviewer: make autopass work
	properly
Date: Fri, 4 Feb 2011 14:51:29 +0000
Message-ID: <alpine.DEB.2.00.1102041451080.7277@kaball-desktop>
References: <1296584702-20138-1-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-2-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-3-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-4-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-5-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-6-git-send-email-ian.jackson@eu.citrix.com>
	<1296584702-20138-7-git-send-email-ian.jackson@eu.citrix.com>
	<alpine.DEB.2.00.1102031236040.7277@kaball-desktop>
	<19786.63117.565925.259009@mariner.uk.xensource.com>
	<alpine.DEB.2.00.1102041110120.7277@kaball-desktop>
	<19788.4355.870526.486505@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19788.4355.870526.486505@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 4 Feb 2011, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 6/6] libxl: vncviewer: make autopass work properly"):
> > Even though it might be tolerable to have this function exits, I still
> > don't see any benefits as opposed to failing with an error, considering
> > that this function returns an integer and the long term plan would be
> > to return an error anyway.
> 
> Very well, how about this.
> 
> > It is just a matter of checking the return value in
> > tools/libxl/xl_cmdimpl.c:vncviewer.
> 
> It already does.  (Nice to see, for a change.)
> 
> Ian.
> 
> 
> libxl: vncviewer: make autopass work properly
> 
> The file we write the vnc password to must be rewound back to the
> beginning, or the vnc viewer will simply get EOF.
> 
> When the syscalls for communicating the password to the vnc client
> fail, bomb out with an error messsage rather than blundering on (and
> probably producing a spurious password prompt).
> 
> Following this patch, xl vncviewer --autopass works, provided the qemu
> patch for writing the password to xenstore has also been applied.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

this patch and the rest of the series:

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>