From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Walmsley Subject: RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support Date: Thu, 10 Feb 2011 22:14:21 -0700 (MST) Message-ID: References: <1297084631-27474-1-git-send-email-rnayak@ti.com> <1297084631-27474-2-git-send-email-rnayak@ti.com> <1297084631-27474-3-git-send-email-rnayak@ti.com> <1297084631-27474-4-git-send-email-rnayak@ti.com> <3754d10e94217aa81846aa1d41fe0a9d@mail.gmail.com> <74b7dfbe67e19da4358f7df0bc4dd8f1@mail.gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from utopia.booyaka.com ([72.9.107.138]:53245 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048Ab1BKFOW (ORCPT ); Fri, 11 Feb 2011 00:14:22 -0500 In-Reply-To: <74b7dfbe67e19da4358f7df0bc4dd8f1@mail.gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: linux-omap@vger.kernel.org, Kevin Hilman , Benoit Cousson , linux-arm-kernel@lists.infradead.org Hi Rajendra On Fri, 11 Feb 2011, Rajendra Nayak wrote: > Failing silently is going to make it more difficult to identify and fix. > Maybe a WARN in else? > > if (cd->clkdm) { > ... > } else > WARN() I was thinking it might be nice to put it right next to the _clkdm_lookup()s in clkdm_init(), since the _clkdm_lookup is what is actually failing. Then we could do a if (!cd->clkdm) continue; in the SoC-specific *_all_wkdep/sleepdep* code, just to keep the system from crashing... Does that sound okay to you? - Paul From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@pwsan.com (Paul Walmsley) Date: Thu, 10 Feb 2011 22:14:21 -0700 (MST) Subject: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support In-Reply-To: <74b7dfbe67e19da4358f7df0bc4dd8f1@mail.gmail.com> References: <1297084631-27474-1-git-send-email-rnayak@ti.com> <1297084631-27474-2-git-send-email-rnayak@ti.com> <1297084631-27474-3-git-send-email-rnayak@ti.com> <1297084631-27474-4-git-send-email-rnayak@ti.com> <3754d10e94217aa81846aa1d41fe0a9d@mail.gmail.com> <74b7dfbe67e19da4358f7df0bc4dd8f1@mail.gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rajendra On Fri, 11 Feb 2011, Rajendra Nayak wrote: > Failing silently is going to make it more difficult to identify and fix. > Maybe a WARN in else? > > if (cd->clkdm) { > ... > } else > WARN() I was thinking it might be nice to put it right next to the _clkdm_lookup()s in clkdm_init(), since the _clkdm_lookup is what is actually failing. Then we could do a if (!cd->clkdm) continue; in the SoC-specific *_all_wkdep/sleepdep* code, just to keep the system from crashing... Does that sound okay to you? - Paul