From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933305Ab1ERRVS (ORCPT ); Wed, 18 May 2011 13:21:18 -0400 Received: from smtp106.prem.mail.ac4.yahoo.com ([76.13.13.45]:42654 "HELO smtp106.prem.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933132Ab1ERRVO (ORCPT ); Wed, 18 May 2011 13:21:14 -0400 X-Yahoo-SMTP: _Dag8S.swBC1p4FJKLCXbs8NQzyse1SYSgnAbY0- X-YMail-OSG: wWE8oIYVM1n43XBS1Rctq2slvj73.pl0mIf7qwZfaBxUauN mU8tU6SSN13LGZvcSm9.yhSis40p.kxCv1KSYBzzlRxMsVLAkroVnc8HO6Kl 8IeQW9sV18kz7saxB5CHAupcqbEMLWIoS3J_vfyFlH.UMMyMzo2epa3Zwhxy Hy1NTrgRCDzdQ93BKxJ8Ja9ln1v9Zg_qhCB8A8iUap9kS2.sffilnd7DliB5 GxR3yafdoVvC9bDWWGIncCsJJVeeJKKX7qp7r51tRjWBwfVgkM5xW9_E4S24 teket8xERCOpBn2SQiCJxE7uJmzHSxAvMNakQz6Qu8JTg8cIoeJWqsd9TVPw Mapx6IgyoRx2w3YudXuNe2_PcGQ-- X-Yahoo-Newman-Property: ymail-3 Date: Wed, 18 May 2011 12:21:08 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Pekka Enberg cc: David Rientjes , Mel Gorman , Andrew Morton , James Bottomley , Colin King , Raghavendra D Prabhu , Jan Kara , Chris Mason , Rik van Riel , Johannes Weiner , linux-fsdevel , linux-mm , linux-kernel , linux-ext4 Subject: Re: [PATCH 2/4] mm: slub: Do not wake kswapd for SLUBs speculative high-order allocations In-Reply-To: <4DD36299.8000108@cs.helsinki.fi> Message-ID: References: <1305295404-12129-1-git-send-email-mgorman@suse.de> <1305295404-12129-3-git-send-email-mgorman@suse.de> <4DD36299.8000108@cs.helsinki.fi> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 May 2011, Pekka Enberg wrote: > On 5/17/11 12:10 AM, David Rientjes wrote: > > On Fri, 13 May 2011, Mel Gorman wrote: > > > > > To avoid locking and per-cpu overhead, SLUB optimisically uses > > > high-order allocations and falls back to lower allocations if they > > > fail. However, by simply trying to allocate, kswapd is woken up to > > > start reclaiming at that order. On a desktop system, two users report > > > that the system is getting locked up with kswapd using large amounts > > > of CPU. Using SLAB instead of SLUB made this problem go away. > > > > > > This patch prevents kswapd being woken up for high-order allocations. > > > Testing indicated that with this patch applied, the system was much > > > harder to hang and even when it did, it eventually recovered. > > > > > > Signed-off-by: Mel Gorman > > Acked-by: David Rientjes > > Christoph? I think this patch is sane although the original rationale was to > workaround kswapd problems. I am mostly fine with it. The concerns that I have is if there is a large series of high order allocs then at some point you would want kswapd to be triggered instead of high order allocs constantly failing. Can we have a "trigger once in a while" functionality? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 82A416B0022 for ; Wed, 18 May 2011 13:21:14 -0400 (EDT) Date: Wed, 18 May 2011 12:21:08 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH 2/4] mm: slub: Do not wake kswapd for SLUBs speculative high-order allocations In-Reply-To: <4DD36299.8000108@cs.helsinki.fi> Message-ID: References: <1305295404-12129-1-git-send-email-mgorman@suse.de> <1305295404-12129-3-git-send-email-mgorman@suse.de> <4DD36299.8000108@cs.helsinki.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: David Rientjes , Mel Gorman , Andrew Morton , James Bottomley , Colin King , Raghavendra D Prabhu , Jan Kara , Chris Mason , Rik van Riel , Johannes Weiner , linux-fsdevel , linux-mm , linux-kernel , linux-ext4 On Wed, 18 May 2011, Pekka Enberg wrote: > On 5/17/11 12:10 AM, David Rientjes wrote: > > On Fri, 13 May 2011, Mel Gorman wrote: > > > > > To avoid locking and per-cpu overhead, SLUB optimisically uses > > > high-order allocations and falls back to lower allocations if they > > > fail. However, by simply trying to allocate, kswapd is woken up to > > > start reclaiming at that order. On a desktop system, two users report > > > that the system is getting locked up with kswapd using large amounts > > > of CPU. Using SLAB instead of SLUB made this problem go away. > > > > > > This patch prevents kswapd being woken up for high-order allocations. > > > Testing indicated that with this patch applied, the system was much > > > harder to hang and even when it did, it eventually recovered. > > > > > > Signed-off-by: Mel Gorman > > Acked-by: David Rientjes > > Christoph? I think this patch is sane although the original rationale was to > workaround kswapd problems. I am mostly fine with it. The concerns that I have is if there is a large series of high order allocs then at some point you would want kswapd to be triggered instead of high order allocs constantly failing. Can we have a "trigger once in a while" functionality? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org