* ipset return value in type_pf_tdel()
@ 2011-05-19 23:09 David Miller
2011-05-20 7:46 ` Jozsef Kadlecsik
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2011-05-19 23:09 UTC (permalink / raw)
To: kadlec; +Cc: netfilter-devel, kaber
Variable 'ret' in this function is set but not used.
I'm thinking that the "return 0" should perhaps be "return ret"
but it maybe should not be and 'ret' should simply be deleted
entirely.
Please take a look at this.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ipset return value in type_pf_tdel()
2011-05-19 23:09 ipset return value in type_pf_tdel() David Miller
@ 2011-05-20 7:46 ` Jozsef Kadlecsik
0 siblings, 0 replies; 2+ messages in thread
From: Jozsef Kadlecsik @ 2011-05-20 7:46 UTC (permalink / raw)
To: David Miller; +Cc: netfilter-devel, kaber
On Thu, 19 May 2011, David Miller wrote:
> Variable 'ret' in this function is set but not used.
>
> I'm thinking that the "return 0" should perhaps be "return ret"
> but it maybe should not be and 'ret' should simply be deleted
> entirely.
>
> Please take a look at this.
I'll look at it and send the fix together with my pending patches.
Best regards,
Jozsef
-
E-mail : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
H-1525 Budapest 114, POB. 49, Hungary
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-20 7:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 23:09 ipset return value in type_pf_tdel() David Miller
2011-05-20 7:46 ` Jozsef Kadlecsik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.