From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH] libxl: basic support for virtio disk Date: Fri, 27 May 2011 16:12:24 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Liu Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Fri, 27 May 2011, Wei Liu wrote: > On Fri, May 27, 2011 at 8:26 PM, Stefano Stabellini > wrote: > > > > I think you should print an error here, because we should never reach > > this point. > > > > You mean we should never setup Xenstore entries for a virtio disk? I meant that the change is for a code path that we are never going to reach with a virtio disk because at the beginning of libxl_device_disk_add libxl__device_disk_dev_number will return -2. But now that I think about it, it is probably a good idea to add the LIBXL_DISK_BACKEND_NONE case anyway because we must think of the most general use case. > > Also I think you need to add the LIBXL_DISK_BACKEND_NONE case to > > libxl_device_disk_del, libxl_device_disk_local_attach and > > libxl_string_to_backend. > > > > I notice those functions. But I haven't decide what to add to them. > But if we are not storing any information in Xenstore for virtio disk, > the modification to these functions should be minimal. right