From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: Re: [PATCH] libxl: basic support for virtio disk
Date: Thu, 2 Jun 2011 17:10:12 +0100
Message-ID: <alpine.DEB.2.00.1106021708180.12963@kaball-desktop>
References: <BANLkTikbJFnVzqhnRy0=Vb0S=pgENDZ_qw@mail.gmail.com>
	<alpine.DEB.2.00.1105271315270.12963@kaball-desktop>
	<BANLkTikM4AJz1jQi2v4vwM=EP7TEfUP-YQ@mail.gmail.com>
	<alpine.DEB.2.00.1105271559170.12963@kaball-desktop>
	<BANLkTikA_Gw8fgQ4K_=eEg=jkx1TDKMSwQ@mail.gmail.com>
	<alpine.DEB.2.00.1105311232300.12963@kaball-desktop>
	<BANLkTimiDzJLiM++TUR1ysksRjPYjBeu2Q@mail.gmail.com>
	<19942.17843.474817.123371@mariner.uk.xensource.com>
	<BANLkTi=HZvj_7BqOAoiJ4cB99OZJmEoLTA@mail.gmail.com>
	<alpine.DEB.2.00.1106021555561.12963@kaball-desktop>
	<19943.46165.598420.601751@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19943.46165.598420.601751@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <liuw@liuw.name>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2 Jun 2011, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] Re: [PATCH] libxl: basic support for virtio disk"):
> > The limitation on the number of partitions is meaningless for virtio and
> > the limitation on the number of disks in arbitrary, as it is arbitrary
> > the current limitation on the number of scsi disks.
> 
> So the code in libxl should accept any disk number that it can
> correctly format into an option to qemu, and allow qemu to deal with
> any resulting problems.

it is going to be probably INT_MAX then


> > Device names like xvda1, xvda2, etc, are currently supported only with
> > PV guests.
> 
> Currently the partition number is ignored.  Nonzero partitions should
> instead then be rejected.
> 

good point