All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH next/mmotm] slub: partly fix freeze in __slab_free
Date: Tue, 12 Jul 2011 10:11:52 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1107121010060.1672@router.home> (raw)
In-Reply-To: <4E1BE5F9.10401@kernel.org>

On Tue, 12 Jul 2011, Pekka Enberg wrote:

> > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> > index 3d76a43..1351d28 100644
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -62,7 +62,7 @@ struct page {
> >   		struct {			/* SLUB cmpxchg_double area */
> >   			void *freelist;
> >   			union {
> > -				unsigned long counters;
> > +				u64	counters;
> >   				struct {
> >   					unsigned inuse:16;
> >   					unsigned objects:15;
> >
>
> Christoph?


counters needs to overlay the bitfields as well as _count. That is problem
with the earlier fix.

Sorry I have had a power outage for the last two days (strange Chicago
weather) and my server is only up for a few minutes and will go down
periodically due to a UPS malfunction. On a generator. Sigh.



  reply	other threads:[~2011-07-12 15:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 18:58 [PATCH next/mmotm] slub: partly fix freeze in __slab_free Hugh Dickins
2011-07-11 19:39 ` Eric Dumazet
2011-07-11 20:46   ` Hugh Dickins
2011-07-12  6:13   ` Pekka Enberg
2011-07-12 15:11     ` Christoph Lameter [this message]
2011-07-12 15:55       ` Christoph Lameter
2011-07-13 11:28         ` Hugh Dickins
2011-07-13 15:47           ` Christoph Lameter
2011-07-13 15:55             ` Christoph Lameter
2011-07-14 16:14               ` Hugh Dickins
2011-07-14 17:26                 ` Christoph Lameter
2011-07-15 19:22                   ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1107121010060.1672@router.home \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=eric.dumazet@gmail.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.