Re: [PATCH 1/3] xen-blkfront: Drop name and minor adjustments for emulated scsi devices

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

On Thu, 14 Jul 2011, Stefan Bader wrote:
> These were intended to avoid the namespace clash when representing
> emulated IDE and SCSI devices. However that seems to confuse users
> more than expected (a disk defined as sda becomes xvde).
> So for now go back to the scheme which does no adjustments. This
> will break when mixing IDE and SCSI names in the configuration of
> guests but should be by now expected.

This patch is fine by me.


> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  drivers/block/xen-blkfront.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 2112822..a41530f 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -125,8 +125,8 @@ static DEFINE_SPINLOCK(minor_lock);
>  #define BLKIF_MINOR_EXT(dev) ((dev)&(~EXTENDED))
>  #define EMULATED_HD_DISK_MINOR_OFFSET (0)
>  #define EMULATED_HD_DISK_NAME_OFFSET (EMULATED_HD_DISK_MINOR_OFFSET / 256)
> -#define EMULATED_SD_DISK_MINOR_OFFSET (EMULATED_HD_DISK_MINOR_OFFSET + (4 * 16))
> -#define EMULATED_SD_DISK_NAME_OFFSET (EMULATED_HD_DISK_NAME_OFFSET + 4)
> +#define EMULATED_SD_DISK_MINOR_OFFSET (0)
> +#define EMULATED_SD_DISK_NAME_OFFSET (EMULATED_SD_DISK_MINOR_OFFSET / 256)
>  
>  #define DEV_NAME	"xvd"	/* name in /dev */
>  
> -- 
> 1.7.4.1
>