All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	David Rientjes <rientjes@google.com>,
	Andi Kleen <andi@firstfloor.org>,
	tj@kernel.org, Metathronius Galabant <m.galabant@googlemail.com>,
	Matt Mackall <mpm@selenic.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Adrian Drzewiecki <z@drze.net>,
	"Li, Shaohua" <shaohua.li@intel.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [slub p4 6/7] slub: per cpu cache for partial pages
Date: Wed, 24 Aug 2011 08:57:55 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1108240856060.24118@router.home> (raw)
In-Reply-To: <1314170783.5245.24.camel@minggr.sh.intel.com>

On Wed, 24 Aug 2011, Lin Ming wrote:

> > Potential future enhancements:
> >
> > 1. The pickup from the partial list could be perhaps be done without disabling
> >   interrupts with some work. The free path already puts the page into the
> >   per cpu partial list without disabling interrupts.
>
> Nice patches!
>
> Could you share possible ways for this potential enhancement?

In order to avoid disabling interrupts in the allocation paths the state
that has to be kept in kmem_cache_cpu needs to be minimized so that it can
be swapped atomically using a this_cpu_cmpxchg. This means getting rid of
the node and slab fields I guess. Working on some patches to that effect.

Once that is done one can with a this_cpu_cmpxchg_double take over the per
cpu slab and then use that information to update the slab page etc.


  reply	other threads:[~2011-08-24 13:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 21:12 [slub p4 0/7] slub: per cpu partial lists V4 Christoph Lameter
2011-08-09 21:12 ` [slub p4 1/7] slub: free slabs without holding locks (V2) Christoph Lameter
2011-08-20 10:32   ` Pekka Enberg
2011-08-20 15:58     ` Christoph Lameter
2011-08-09 21:12 ` [slub p4 2/7] slub: Remove useless statements in __slab_alloc Christoph Lameter
2011-08-20 10:44   ` Pekka Enberg
2011-08-20 16:01     ` Christoph Lameter
2011-08-09 21:12 ` [slub p4 3/7] slub: Prepare inuse field in new_slab() Christoph Lameter
2011-08-09 21:12 ` [slub p4 4/7] slub: pass kmem_cache_cpu pointer to get_partial() Christoph Lameter
2011-08-09 21:12 ` [slub p4 5/7] slub: return object pointer from get_partial() / new_slab() Christoph Lameter
2011-08-09 21:12 ` [slub p4 6/7] slub: per cpu cache for partial pages Christoph Lameter
2011-08-20 10:40   ` Pekka Enberg
2011-08-20 16:00     ` Christoph Lameter
     [not found]   ` <CAF1ivSaH9fh6_QvuBkLc5t=zC4mPEAD5ZzsxOuPruDwG9MiZzw@mail.gmail.com>
2011-08-24  7:26     ` Lin Ming
2011-08-24 13:57       ` Christoph Lameter [this message]
2011-08-09 21:12 ` [slub p4 7/7] slub: update slabinfo tools to report per cpu partial list statistics Christoph Lameter
2011-08-13 18:28 ` [slub p4 0/7] slub: per cpu partial lists V4 David Rientjes
2011-08-15  8:44   ` Pekka Enberg
2011-08-15 14:29   ` Christoph Lameter
2011-08-20 10:48 ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1108240856060.24118@router.home \
    --to=cl@linux.com \
    --cc=andi@firstfloor.org \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.galabant@googlemail.com \
    --cc=ming.m.lin@intel.com \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=rientjes@google.com \
    --cc=shaohua.li@intel.com \
    --cc=tj@kernel.org \
    --cc=z@drze.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.