From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] Re: [PATCH v4 2/2] xen: modify kernel mappings corresponding to granted pages
Date: Thu, 29 Sep 2011 11:00:38 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1109291059540.3519@kaball-desktop> (raw)
In-Reply-To: <20110928230535.GA23001@phenom.oracle.com>
On Thu, 29 Sep 2011, Konrad Rzeszutek Wilk wrote:
> > > > But aren't that 'range of virtual address' of struct pages? You
> > > > are using 'alloc_xenballooned_pages' to get those pages and that is
> > > > what the 'range of virtual adresses' is walking through.
> > >
> > > it is not the same range of virtual addresses
> >
> > OK, but the pte_maddr is the same, isn't it?
>
> No it is not. It is the machine address of the PTE entry that
> points to the 'struct page' (kernel linear address), while the
> find_grant_pte's gets the machine address of the PTE entry that
> points to the user pages. Completlely different machine addresses
> of the PTEs.
Right
> Can you add a comment to the patch saying something along what
> I just said? Just in case somebody is as thick as I am when looking
> at this code/patch.
Sure
> Otherwise the patch looks fine - just fix up the SetPagePrivate,
> the PAGE_GRANT bit, and add extra comments and I am ready to stick it
> on my queue.
OK!
prev parent reply other threads:[~2011-09-29 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 18:45 [PATCH v4 2/2] xen: modify kernel mappings corresponding to granted pages Stefano Stabellini
2011-09-08 18:45 ` Stefano Stabellini
2011-09-21 14:58 ` konrad.wilk
2011-09-23 13:55 ` Stefano Stabellini
2011-09-23 14:45 ` Konrad Rzeszutek Wilk
2011-09-23 14:45 ` Konrad Rzeszutek Wilk
2011-09-27 15:47 ` Stefano Stabellini
2011-09-28 13:12 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-09-28 23:05 ` Konrad Rzeszutek Wilk
2011-09-29 10:00 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1109291059540.3519@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.