Re: [PATCH v7 0/5] build upstream qemu and seabios by default

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

On Mon, 10 Oct 2011, Ian Jackson wrote:
> Stefano Stabellini writes ("[Xen-devel] [PATCH v7 0/5] build upstream qemu and seabios by default"):
> > this is the sixth version of the patch series to introduce upstream qemu
> > and seabios in the xen-unstable build system.
> 
> I did this (on my workstation, running Debian squeeze i386):
> 
>  * hg clean --all
>  * Apply this series (it applied cleanly)
>  * cp ../.config .  (see below)
>  * in the referenced qemu-iwj.git dir, git-clean -xdf
>  * (make -j4 && echo ok.) 2>&1 | tee ../log
> 
> My ../.config contains only
>  
> CONFIG_QEMU=/u/iwj/work/1/qemu-iwj.git
> 
> and the referenced directory is at git changeset
> 25378e0a76b282127e9ab8933a4defbc91db3862.
> 
> The result was the error you see below.
> 
> After this, the directory "tools/qemu-xen-dir-remote" is at
> 6dd84c71dff047f9e492d67e7c99928d09202760.
> 
> IIRC this is the same problem that v5 and v6 had.  Please come back
> when you've actually fixed it.
> 
> Ian.
> 
> 
> make[1]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/xen'
> Switched to a new branch 'dummy'
> cd qemu-xen-dir; \
>         ./configure --enable-xen --target-list=i386-softmmu \
>                 --source-path=$ROOT \
>                 --extra-cflags="-I/u/iwj/work/xen-unstable-tools.hg/tools/../tools/include \
>                 -I/u/iwj/work/xen-unstable-tools.hg/tools/../tools/libxc \
>                 -I/u/iwj/work/xen-unstable-tools.hg/tools/../tools/xenstore" \
>                 --extra-ldflags="-L/u/iwj/work/xen-unstable-tools.hg/tools/../tools/libxc \
>                 -L/u/iwj/work/xen-unstable-tools.hg/tools/../tools/libxenstore" \
>                 --bindir=/usr/lib/xen/bin \
>                 --disable-kvm \
> 
> ERROR
> ERROR: User requested feature xen
> ERROR: configure was not able to find it
> ERROR
> make[1]: *** [qemu-xen-dir-find] Error 1
> make[1]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/tools'
> make: *** [tools/qemu-xen-dir] Error 2
> 

I have just realized that I did all my tests on a box that has xen
properly installed under /usr so it doesn't need all the --extra-cflags
and --extra-ldflags runes.
Changing dev box made me uncover two bugs:

- a typo in tools/Makefile (libxenstore instead of xenstore);

- a dependency problem: qemu's configure script needs libxc and xenstore
to be already built but we are calling it before building them. The
solution is to move the call to configure after we build libxc and xenstore.