From: Christoph Lameter <cl@linux.com>
To: Tejun Heo <tj@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] slab fixes for 3.2-rc4
Date: Tue, 20 Dec 2011 10:31:09 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1112201027360.21231@router.home> (raw)
In-Reply-To: <20111220162315.GC10752@google.com>
On Tue, 20 Dec 2011, Tejun Heo wrote:
> This is __this_cpu_add() + preemption disabled check. Should be
> removed. Christoph, is there a use case where __this_cpu_XXX() is
> used without preemption disabled? Why doesn't it have preemption
> check?
We discussed this before and said that it would be possible to add a
preemption check there. We would need to verify that there is no use case
of __this_cpu_XXX operations in preemptable context. There used to be a
case where we did not care about the races for the vmstat counters but
that seems to have been changed. Not aware of any other use case like
that.
next prev parent reply other threads:[~2011-12-20 16:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 18:02 [GIT PULL] slab fixes for 3.2-rc4 Pekka Enberg
2011-11-29 19:29 ` Linus Torvalds
2011-11-29 19:38 ` Linus Torvalds
2011-12-20 9:47 ` Pekka Enberg
2011-12-20 16:23 ` Tejun Heo
2011-12-20 16:31 ` Christoph Lameter [this message]
2011-12-20 19:28 ` Linus Torvalds
2011-12-20 20:28 ` Tejun Heo
2011-12-21 8:08 ` Pekka Enberg
2011-12-21 17:09 ` Tejun Heo
2011-12-21 15:16 ` Christoph Lameter
2011-12-21 17:05 ` Tejun Heo
2011-12-22 2:19 ` Linus Torvalds
2011-12-22 16:05 ` Tejun Heo
2011-12-28 10:25 ` Benjamin Herrenschmidt
2011-12-22 14:58 ` Christoph Lameter
2011-12-22 16:08 ` Tejun Heo
2011-12-22 17:58 ` Christoph Lameter
2011-12-22 18:03 ` Ingo Molnar
2011-12-22 18:31 ` Linus Torvalds
2011-12-23 16:55 ` Christoph Lameter
2011-12-23 20:54 ` Linus Torvalds
2012-01-04 15:30 ` Christoph Lameter
2012-01-04 16:07 ` Linus Torvalds
2012-01-04 17:00 ` Christoph Lameter
2012-01-04 23:10 ` Linus Torvalds
2012-01-05 19:15 ` Christoph Lameter
2012-01-05 19:27 ` Linus Torvalds
2011-12-22 18:47 ` Tejun Heo
2011-12-20 16:26 ` Christoph Lameter
2011-12-21 8:06 ` Pekka Enberg
2011-12-21 15:20 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1112201027360.21231@router.home \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.