All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: Chris Ball <cjb@laptop.org>, Tony Lindgren <tony@atomide.com>,
	Chase Maupin <Chase.Maupin@ti.com>,
	linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
	sakoman@gmail.com
Subject: Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices
Date: Thu, 12 Apr 2012 11:56:06 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1204121130370.29473@utopia.booyaka.com> (raw)
In-Reply-To: <4F86A461.4010006@linaro.org>

Hello Tushar,

On Thu, 12 Apr 2012, Tushar Behera wrote:

> With this patch, I continuously get following message on my console.
> (Tested on Origen board, based on EXYNOS4210).
> 
> mmc0: Too large timeout requested for CMD25!
> 
> So, with this change, should we update sdhci_calc_timeout() also?

Looks like most of the host drivers that range-check the timeout value 
silently clamp it at the hardware-supported maximum value:

drivers/mmc/host/atmel-mci.c
drivers/mmc/host/davinci_mmc.c
drivers/mmc/host/mvsdio.c
drivers/mmc/host/omap_hsmmc.c
drivers/mmc/host/wbsd.c
drivers/mmc/host/tifm_sd.c

So maybe try the same thing for your driver?

Of course it seems that some drivers don't range-check the timeout value 
at all :-(

drivers/mmc/host/bfin_sdh.c
drivers/mmc/host/mmci.c
drivers/mmc/host/msm_sdcc.c
drivers/mmc/host/pxamci.c
drivers/mmc/host/mxs-mmc.c
drivers/mmc/host/omap.c



- Paul

  reply	other threads:[~2012-04-12 17:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01 17:26 [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices Chase Maupin
2012-03-06 12:54 ` Maupin, Chase
2012-03-09  4:38 ` Chris Ball
2012-03-09 13:06   ` Maupin, Chase
2012-03-12 10:58   ` Paul Walmsley
2012-03-12 11:10     ` Paul Walmsley
2012-03-12 14:37     ` Maupin, Chase
2012-03-16  3:22     ` Chris Ball
2012-04-05 22:08       ` Tony Lindgren
2012-04-05 22:15         ` Chris Ball
2012-04-05 23:44           ` Paul Walmsley
2012-04-05 23:54             ` Chris Ball
2012-04-12  9:46               ` Tushar Behera
2012-04-12 17:56                 ` Paul Walmsley [this message]
2012-04-12 18:19                   ` Chris Ball
2012-04-14  9:38                     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1204121130370.29473@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=Chase.Maupin@ti.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sakoman@gmail.com \
    --cc=tony@atomide.com \
    --cc=tushar.behera@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.