From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "rshriram@cs.ubc.ca" <rshriram@cs.ubc.ca>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH v6 1/3] libxc: introduce XC_SAVE_ID_TOOLSTACK
Date: Thu, 12 Apr 2012 13:59:33 +0100 [thread overview]
Message-ID: <alpine.DEB.2.00.1204121359160.15151@kaball-desktop> (raw)
In-Reply-To: <1334232105.16387.102.camel@zakaz.uk.xensource.com>
On Thu, 12 Apr 2012, Ian Campbell wrote:
> On Thu, 2012-04-12 at 12:58 +0100, Stefano Stabellini wrote:
> > On Thu, 12 Apr 2012, Ian Jackson wrote:
> > > Stefano Stabellini writes ("Re: [Xen-devel] [PATCH v6 1/3] libxc: introduce XC_SAVE_ID_TOOLSTACK"):
> > > > On Tue, 3 Apr 2012, Ian Jackson wrote:
> > > ...
> > > > > Although I do have one comment: are you sure it's appropriate that the
> > > > > "toolstack data" is silently thrown away if the restore caller doesn't
> > > > > supply the relevant callback ?
> > > >
> > > > We should print a warning in that case and try to continue
> > >
> > > Why is it not appropriate to bomb out ? I am not a fan of warnings
> > > (which end up dumped to some ignored logfile) for things which might
> > > be critical problems.
> >
> > because there is a significant chance that the guest will resume
> > correctly anyway (it depends on the guest status and the VM config)
>
> But there is some non-zero chance that it won't, in which case we've
> just silently killed the destination VM and told the source machine that
> everything is OK, so it won't resume the original. That's not good. I
> think we should propagate the error here.
OK
next prev parent reply other threads:[~2012-04-12 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 12:24 [PATCH v6 0/3] libxl: save/restore qemu physmap Stefano Stabellini
2012-03-20 12:24 ` [PATCH v6 1/3] libxc: introduce XC_SAVE_ID_TOOLSTACK Stefano Stabellini
2012-04-03 13:50 ` Ian Jackson
2012-04-12 10:35 ` Stefano Stabellini
2012-04-12 11:33 ` Ian Jackson
2012-04-12 11:58 ` Stefano Stabellini
2012-04-12 12:01 ` Ian Campbell
2012-04-12 12:59 ` Stefano Stabellini [this message]
2012-03-20 12:24 ` [PATCH v6 2/3] libxl: save/restore qemu's physmap Stefano Stabellini
2012-04-03 14:01 ` Ian Jackson
2012-04-12 10:51 ` Stefano Stabellini
2012-03-20 12:24 ` [PATCH v6 3/3] libxl_qmp: remove libxl__qmp_migrate, introduce libxl__qmp_save Stefano Stabellini
2012-04-03 14:05 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1204121359160.15151@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.