From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Walmsley Subject: Re: [PATCH] ARM: OMAP: clock: cleanup CPUfreq leftovers, fix build errors Date: Fri, 13 Apr 2012 16:38:59 -0600 (MDT) Message-ID: References: <1334350335-1250-1-git-send-email-khilman@ti.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from utopia.booyaka.com ([72.9.107.138]:48190 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119Ab2DMWjA (ORCPT ); Fri, 13 Apr 2012 18:39:00 -0400 In-Reply-To: <1334350335-1250-1-git-send-email-khilman@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Fri, 13 Apr 2012, Kevin Hilman wrote: > Now that we have OPP layer, and OMAP CPUfreq driver is using it, we no > longer need/use the clock framework code for filling up CPUfreq > tables. Remove it. > > Removing this code also eliminates build errors when CPU_FREQ_TABLE > support is not enabled. > > Thanks to Russell King for pointing out the parts I missed under > plat-omap in the original version and also pointing out the build > errors when CPUFREQ_TABLE support was not enabled. > > Cc: Russell King > Signed-off-by: Kevin Hilman > --- > Tony/Paul, can you queue this up ASAP for v3.4-rc? This was a cleanup > that was targetted to go in to v3.4, but missed the merge window. The > cleanup is still needed, but now it's also a fix since this dead code > also causes build errors when CPU_FREQ_TABLE support is not enabled. > > Also, if we don't merge this patch, we'll have to rework it because > Russell has queued an alternate fix to this which changes some of this > code that should be removed instead: > http://marc.info/?l=linux-arm-kernel&m=133434335009356&w=2 > However, if we get this fix in soon, Russell is willing to drop his > version. > > arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 80 -------------------------- > arch/arm/mach-omap2/clock.c | 5 -- > arch/arm/mach-omap2/clock.h | 8 --- > arch/arm/plat-omap/clock.c | 26 --------- > arch/arm/plat-omap/include/plat/clock.h | 10 ---- Acked-by: Paul Walmsley - Paul From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@pwsan.com (Paul Walmsley) Date: Fri, 13 Apr 2012 16:38:59 -0600 (MDT) Subject: [PATCH] ARM: OMAP: clock: cleanup CPUfreq leftovers, fix build errors In-Reply-To: <1334350335-1250-1-git-send-email-khilman@ti.com> References: <1334350335-1250-1-git-send-email-khilman@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 13 Apr 2012, Kevin Hilman wrote: > Now that we have OPP layer, and OMAP CPUfreq driver is using it, we no > longer need/use the clock framework code for filling up CPUfreq > tables. Remove it. > > Removing this code also eliminates build errors when CPU_FREQ_TABLE > support is not enabled. > > Thanks to Russell King for pointing out the parts I missed under > plat-omap in the original version and also pointing out the build > errors when CPUFREQ_TABLE support was not enabled. > > Cc: Russell King > Signed-off-by: Kevin Hilman > --- > Tony/Paul, can you queue this up ASAP for v3.4-rc? This was a cleanup > that was targetted to go in to v3.4, but missed the merge window. The > cleanup is still needed, but now it's also a fix since this dead code > also causes build errors when CPU_FREQ_TABLE support is not enabled. > > Also, if we don't merge this patch, we'll have to rework it because > Russell has queued an alternate fix to this which changes some of this > code that should be removed instead: > http://marc.info/?l=linux-arm-kernel&m=133434335009356&w=2 > However, if we get this fix in soon, Russell is willing to drop his > version. > > arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 80 -------------------------- > arch/arm/mach-omap2/clock.c | 5 -- > arch/arm/mach-omap2/clock.h | 8 --- > arch/arm/plat-omap/clock.c | 26 --------- > arch/arm/plat-omap/include/plat/clock.h | 10 ---- Acked-by: Paul Walmsley - Paul