From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933128Ab2EKSGp (ORCPT ); Fri, 11 May 2012 14:06:45 -0400 Received: from smtp108.prem.mail.ac4.yahoo.com ([76.13.13.47]:23271 "HELO smtp108.prem.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933067Ab2EKSGl (ORCPT ); Fri, 11 May 2012 14:06:41 -0400 X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: sSe1gaUVM1kSFynf23djkWegyS3yy1OwKvLkY1.W88wFOST GtIumnc5T1Evw4XGe0vYKupI3dxTowEFRWY1NblCk5S0YqtD9vOfdLsa9MeD N.H97pjNCZLO9BLeXm_sBGg8xBK2CLypioFL8uBh.z_A3nYhj.w7rUdWKMq_ fumzejLOVgQ6Hnm5uZc0pi8bSlxZR0cFTBika4jqmtYTot4aqCGw_2R3giGA dNxGB5bapIcTg78EOfPas.4CwFRMIddJ_fdrXeFeqpWe3GpDlDGG7kk3fQWw gUuNbP4sxVN9YECMiklbyru11rSwbaxlC0S3MwU9qGE.Dl_jo3qbY0iWCpZu ynr9ic.wphwSDht2TuTMVKxk6ZmvZH_TwXKAOUE3cXk22iKOEIztZGAcrrO8 biqoBQV.pMOLPhi2fzKno87BaXYDLeRT9IBkb X-Yahoo-SMTP: _Dag8S.swBC1p4FJKLCXbs8NQzyse1SYSgnAbY0- Date: Fri, 11 May 2012 13:06:36 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Glauber Costa cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, Pekka Enberg Subject: Re: [PATCH v2 04/29] slub: always get the cache from its page in kfree In-Reply-To: <4FAD531D.6030007@parallels.com> Message-ID: References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-5-git-send-email-glommer@parallels.com> <4FAD531D.6030007@parallels.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 May 2012, Glauber Costa wrote: > > Adding a VM_BUG_ON may be useful to make sure that kmem_cache_free is > > always passed the correct slab cache. > > Well, problem is , it isn't always passed the "correct" slab cache. > At least not after this series, since we'll have child caches associated with > the main cache. > > So we'll pass, for instance, kmem_cache_free(dentry_cache...), but will in > fact free from the memcg copy of the dentry cache. Urg. But then please only do this for the MEMCG case and add a fat big warning in kmem_cache_free. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: Re: [PATCH v2 04/29] slub: always get the cache from its page in kfree Date: Fri, 11 May 2012 13:06:36 -0500 (CDT) Message-ID: References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-5-git-send-email-glommer@parallels.com> <4FAD531D.6030007@parallels.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1336759600; bh=gv6IROagpWvwVLKhY9c7/hbqqq0Wg/iTDzl8z3IwF3g=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Date:From:X-X-Sender:To:cc:Subject:In-Reply-To:Message-ID:References:User-Agent:MIME-Version:Content-Type; b=eV4TuJJwuQKqe6EYEbFOfD4OzO199QRG8Plxa6KNbD2xHkrIMTZBE6g/QdJjoRw0CdC6UV6rgtwE2SZc4GFRbwScw2vMSOxKMcSrd2sCEG7GoxEO6knE1jFHzxnGHNqyGLqXGQ+YzFayOLyT5GKrohS/psiVKHO3FyJOF0kDFnY= In-Reply-To: <4FAD531D.6030007@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, Pekka Enberg On Fri, 11 May 2012, Glauber Costa wrote: > > Adding a VM_BUG_ON may be useful to make sure that kmem_cache_free is > > always passed the correct slab cache. > > Well, problem is , it isn't always passed the "correct" slab cache. > At least not after this series, since we'll have child caches associated with > the main cache. > > So we'll pass, for instance, kmem_cache_free(dentry_cache...), but will in > fact free from the memcg copy of the dentry cache. Urg. But then please only do this for the MEMCG case and add a fat big warning in kmem_cache_free. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org