From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH v5 2/8] libxl: libxl__device_disk_local_attach return a new libxl_device_disk Date: Mon, 14 May 2012 14:04:28 +0100 Message-ID: References: <1336130000-27261-2-git-send-email-stefano.stabellini@eu.citrix.com> <20388.878.645214.92917@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20388.878.645214.92917@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Fri, 4 May 2012, Ian Jackson wrote: > Stefano Stabellini writes ("[PATCH v5 2/8] libxl: libxl__device_disk_local_attach return a new libxl_device_disk"): > > Introduce a new libxl_device_disk** parameter to > > libxl__device_disk_local_attach, the parameter is allocated on the gc by > > libxl__device_disk_local_attach. It is going to fill it with > > informations about the new locally attached disk. The new > > libxl_device_disk should be passed to libxl_device_disk_local_detach > > afterwards. > ... > > diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c > > index fc771ff..55dc55c 100644 > > --- a/tools/libxl/libxl_internal.c > > +++ b/tools/libxl/libxl_internal.c > ... > > LIBXL__LOG(ctx, LIBXL__LOG_DEBUG, "locally attaching qdisk %s\n", > > - disk->pdev_path); > > + in_disk->pdev_path); > > I think in_disk->pdev_path can be NULL here ? It cannot, unless a wrong configuration was provided. In that case we'll fail to open the empty disk later on. > Also log messages should not contain "\n"; the logging functions add > it. OK