From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964992Ab2EOVzK (ORCPT ); Tue, 15 May 2012 17:55:10 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:40873 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933045Ab2EOVzH (ORCPT ); Tue, 15 May 2012 17:55:07 -0400 Date: Tue, 15 May 2012 14:55:04 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Glauber Costa , Pekka Enberg cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, Christoph Lameter Subject: Re: [PATCH v2 02/29] slub: fix slab_state for slub In-Reply-To: <1336758272-24284-3-git-send-email-glommer@parallels.com> Message-ID: References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-3-git-send-email-glommer@parallels.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 May 2012, Glauber Costa wrote: > When the slub code wants to know if the sysfs state has already been > initialized, it tests for slab_state == SYSFS. This is quite fragile, > since new state can be added in the future (it is, in fact, for > memcg caches). This patch fixes this behavior so the test matches > >= SYSFS, as all other state does. > > Signed-off-by: Glauber Costa Acked-by: David Rientjes Can be merged now, there's no dependency on the rest of this patchset. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx167.postini.com [74.125.245.167]) by kanga.kvack.org (Postfix) with SMTP id 19B1E6B004D for ; Tue, 15 May 2012 17:55:08 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so298635pbb.14 for ; Tue, 15 May 2012 14:55:07 -0700 (PDT) Date: Tue, 15 May 2012 14:55:04 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH v2 02/29] slub: fix slab_state for slub In-Reply-To: <1336758272-24284-3-git-send-email-glommer@parallels.com> Message-ID: References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-3-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa , Pekka Enberg Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, Christoph Lameter On Fri, 11 May 2012, Glauber Costa wrote: > When the slub code wants to know if the sysfs state has already been > initialized, it tests for slab_state == SYSFS. This is quite fragile, > since new state can be added in the future (it is, in fact, for > memcg caches). This patch fixes this behavior so the test matches > >= SYSFS, as all other state does. > > Signed-off-by: Glauber Costa Acked-by: David Rientjes Can be merged now, there's no dependency on the rest of this patchset. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [PATCH v2 02/29] slub: fix slab_state for slub Date: Tue, 15 May 2012 14:55:04 -0700 (PDT) Message-ID: References: <1336758272-24284-1-git-send-email-glommer@parallels.com> <1336758272-24284-3-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=VNxTgAR+mI7Ev8mNMF6yCxjgg4IMbf+W8yOFj8tTQq0=; b=YNP7/KiaZyCRK005f7b7686yBZsO5bVWREz+RFTNX499v2ttg5p3nc128MLiKxRsVL CqA05J/WRJOKotK+d4kzwFpM4MiSFmZ0+TpgYG7Wcp6cYdFYh60vZCCJVGBomLgutrB2 mmGwGnj/boP+c0CVDGx2c2qXoATlsiQHkwqWLLWspY3ntfc918z4s/egfqv9p3ScwS45 VcHDgYkGh3/yQgQYNrkO0aedlYj01VP+1oyynOgLTfKE0Pi+P7a14CuWN7st3zNrddw7 CqYj59r1f97PGp0A8HsxYPwO85JZN0tN+bB1086TBndqYJrenY6nV7z/fYqBVld2phMs CTpA== In-Reply-To: <1336758272-24284-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa , Pekka Enberg Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Christoph Lameter On Fri, 11 May 2012, Glauber Costa wrote: > When the slub code wants to know if the sysfs state has already been > initialized, it tests for slab_state == SYSFS. This is quite fragile, > since new state can be added in the future (it is, in fact, for > memcg caches). This patch fixes this behavior so the test matches > >= SYSFS, as all other state does. > > Signed-off-by: Glauber Costa Acked-by: David Rientjes Can be merged now, there's no dependency on the rest of this patchset.