From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756776Ab2FZFYt (ORCPT ); Tue, 26 Jun 2012 01:24:49 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:61296 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799Ab2FZFYr (ORCPT ); Tue, 26 Jun 2012 01:24:47 -0400 Date: Mon, 25 Jun 2012 22:24:44 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrew Morton cc: Glauber Costa , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg , Suleiman Souhlal Subject: Re: [PATCH 09/11] memcg: propagate kmem limiting information to children In-Reply-To: <20120625162352.51997c5a.akpm@linux-foundation.org> Message-ID: References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-10-git-send-email-glommer@parallels.com> <20120625162352.51997c5a.akpm@linux-foundation.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jun 2012, Andrew Morton wrote: > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -287,7 +287,11 @@ struct mem_cgroup { > > * Should the accounting and control be hierarchical, per subtree? > > */ > > bool use_hierarchy; > > - bool kmem_accounted; > > + /* > > + * bit0: accounted by this cgroup > > + * bit1: accounted by a parent. > > + */ > > + volatile unsigned long kmem_accounted; > > I suggest > > unsigned long kmem_accounted; /* See KMEM_ACCOUNTED_*, below */ > > > bool oom_lock; > > atomic_t under_oom; > > @@ -340,6 +344,9 @@ struct mem_cgroup { > > #endif > > }; > > > > +#define KMEM_ACCOUNTED_THIS 0 > > +#define KMEM_ACCOUNTED_PARENT 1 > > And then document the fields here. > In hex, please? From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [PATCH 09/11] memcg: propagate kmem limiting information to children Date: Mon, 25 Jun 2012 22:24:44 -0700 (PDT) Message-ID: References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-10-git-send-email-glommer@parallels.com> <20120625162352.51997c5a.akpm@linux-foundation.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=QZaBdsOU+yF2ruuencQevhDNLhr5HUZRucHHn/b5FkE=; b=CQg6QS7V581aI/0FvffHvN6sUIBEKHtihIQZu0FymXStpabZWtb6A25mUFCFJ/f9XI bkd1UVg4WFh2IDdhnZ/deNfPAuUqcG+n04qq86PqPzfV6OQBTgalWkWcyb1x/bdTeew+ jF6C2iF2mecAtPLRh3/IiqB75UlMb+Eb36JemyXUzX7m9QulSXmSz7srM+K83NE5BDi6 eiwjImI3VUgzlqtcOrGm+pSsBnZRVlBqeWX8XNJaGyzf15N9aXZteS8kMoiLj7Rbrjs6 kxkhEZrrQ2L5zlIOJ7SM7ETWilXFqrw7wJBpvNAEGs7sE/DtVjEDlbsGSBK8610ED4Nd LLFg== In-Reply-To: <20120625162352.51997c5a.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Glauber Costa , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg , Suleiman Souhlal On Mon, 25 Jun 2012, Andrew Morton wrote: > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -287,7 +287,11 @@ struct mem_cgroup { > > * Should the accounting and control be hierarchical, per subtree? > > */ > > bool use_hierarchy; > > - bool kmem_accounted; > > + /* > > + * bit0: accounted by this cgroup > > + * bit1: accounted by a parent. > > + */ > > + volatile unsigned long kmem_accounted; > > I suggest > > unsigned long kmem_accounted; /* See KMEM_ACCOUNTED_*, below */ > > > bool oom_lock; > > atomic_t under_oom; > > @@ -340,6 +344,9 @@ struct mem_cgroup { > > #endif > > }; > > > > +#define KMEM_ACCOUNTED_THIS 0 > > +#define KMEM_ACCOUNTED_PARENT 1 > > And then document the fields here. > In hex, please? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org