From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316Ab2FZJDR (ORCPT ); Tue, 26 Jun 2012 05:03:17 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56859 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753634Ab2FZJDQ (ORCPT ); Tue, 26 Jun 2012 05:03:16 -0400 Date: Tue, 26 Jun 2012 02:03:13 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Glauber Costa cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Frederic Weisbecker , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg , Suleiman Souhlal Subject: Re: [PATCH 05/11] Add a __GFP_KMEMCG flag In-Reply-To: <4FE95FF0.3000300@parallels.com> Message-ID: References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-6-git-send-email-glommer@parallels.com> <4FE95FF0.3000300@parallels.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jun 2012, Glauber Costa wrote: > > > >This flag is used to indicate to the callees that this allocation will be > > > >serviced to the kernel. It is not supposed to be passed by the callers > > > >of kmem_cache_alloc, but rather by the cache core itself. > > > > > > Not sure what "serviced to the kernel" means, does this mean that the > > memory will not be accounted for to the root memcg? > > > In this context, it means that is a kernel allocation, not a userspace one > (but in process context, of course), *and* it is to be accounted a > specific memcg. > Ah, that makes sense. I think it would help if this was included in the changelog as well as a specifying that it is accounted to current's memcg at the time of the allocation in a comment in the code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx135.postini.com [74.125.245.135]) by kanga.kvack.org (Postfix) with SMTP id 4721B6B016E for ; Tue, 26 Jun 2012 05:03:17 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so9621798pbb.14 for ; Tue, 26 Jun 2012 02:03:15 -0700 (PDT) Date: Tue, 26 Jun 2012 02:03:13 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 05/11] Add a __GFP_KMEMCG flag In-Reply-To: <4FE95FF0.3000300@parallels.com> Message-ID: References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-6-git-send-email-glommer@parallels.com> <4FE95FF0.3000300@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Frederic Weisbecker , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg , Suleiman Souhlal On Tue, 26 Jun 2012, Glauber Costa wrote: > > > >This flag is used to indicate to the callees that this allocation will be > > > >serviced to the kernel. It is not supposed to be passed by the callers > > > >of kmem_cache_alloc, but rather by the cache core itself. > > > > > > Not sure what "serviced to the kernel" means, does this mean that the > > memory will not be accounted for to the root memcg? > > > In this context, it means that is a kernel allocation, not a userspace one > (but in process context, of course), *and* it is to be accounted a > specific memcg. > Ah, that makes sense. I think it would help if this was included in the changelog as well as a specifying that it is accounted to current's memcg at the time of the allocation in a comment in the code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org