From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Walmsley Subject: RE: how to specify dma_mask and coherent_dma_mask in hwmod Date: Thu, 28 Jun 2012 10:32:46 -0600 (MDT) Message-ID: References: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from utopia.booyaka.com ([72.9.107.138]:60807 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995Ab2F1Qcr (ORCPT ); Thu, 28 Jun 2012 12:32:47 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Bedia, Vaibhav" Cc: "N, Mugunthan V" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Cousson, Benoit" , "Hilman, Kevin" On Thu, 28 Jun 2012, Bedia, Vaibhav wrote: > On Thu, Jun 28, 2012 at 21:22:54, Paul Walmsley wrote: > [...] > > > > dma_mask and coherent_dma_mask can be specified during > > device creation. See usb_musb_init() in arch/arm/mach-omap2/usb-musb.c > > for an example. > > > > Thanks for pointing this out. Should omap_device_build() start handling this > or would that be an overkill? If both dma_mask and coherent_dma_mask are always 0xffffffff on all OMAPs and we can set that safely even for devices that don't use it, then yeah it sounds like we should set it. Care to send a patch? - Paul From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@pwsan.com (Paul Walmsley) Date: Thu, 28 Jun 2012 10:32:46 -0600 (MDT) Subject: how to specify dma_mask and coherent_dma_mask in hwmod In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 28 Jun 2012, Bedia, Vaibhav wrote: > On Thu, Jun 28, 2012 at 21:22:54, Paul Walmsley wrote: > [...] > > > > dma_mask and coherent_dma_mask can be specified during > > device creation. See usb_musb_init() in arch/arm/mach-omap2/usb-musb.c > > for an example. > > > > Thanks for pointing this out. Should omap_device_build() start handling this > or would that be an overkill? If both dma_mask and coherent_dma_mask are always 0xffffffff on all OMAPs and we can set that safely even for devices that don't use it, then yeah it sounds like we should set it. Care to send a patch? - Paul