From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [Patch v5 5/7] acpi_memhotplug.c: don't allow to eject the memory device if it is being used Date: Thu, 15 Nov 2012 15:39:08 -0800 (PST) Message-ID: References: <1352962777-24407-1-git-send-email-wency@cn.fujitsu.com> <1352962777-24407-6-git-send-email-wency@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:56047 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054Ab2KOXjL (ORCPT ); Thu, 15 Nov 2012 18:39:11 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so1506604pbc.19 for ; Thu, 15 Nov 2012 15:39:11 -0800 (PST) In-Reply-To: <1352962777-24407-6-git-send-email-wency@cn.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Wen Congyang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" , Andrew Morton , Yasuaki Ishimatsu , Lai Jiangshan , Jiang Liu , KOSAKI Motohiro , Minchan Kim , Mel Gorman , Konrad Rzeszutek Wilk , Toshi Kani , Jiang Liu , Benjamin Herrenschmidt , Paul Mackerras , Christoph Lameter On Thu, 15 Nov 2012, Wen Congyang wrote: > We eject the memory device even if it is in use. It is very dangerous, > and it will cause the kernel to be panicked. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Yasuaki Ishimatsu > CC: Rafael J. Wysocki > CC: Konrad Rzeszutek Wilk > Signed-off-by: Wen Congyang Acked-by: David Rientjes Thanks for adding the comment about why num_enabled is incremented for -EEXIST. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx117.postini.com [74.125.245.117]) by kanga.kvack.org (Postfix) with SMTP id E7AD96B0074 for ; Thu, 15 Nov 2012 18:39:11 -0500 (EST) Received: by mail-da0-f41.google.com with SMTP id i14so969306dad.14 for ; Thu, 15 Nov 2012 15:39:11 -0800 (PST) Date: Thu, 15 Nov 2012 15:39:08 -0800 (PST) From: David Rientjes Subject: Re: [Patch v5 5/7] acpi_memhotplug.c: don't allow to eject the memory device if it is being used In-Reply-To: <1352962777-24407-6-git-send-email-wency@cn.fujitsu.com> Message-ID: References: <1352962777-24407-1-git-send-email-wency@cn.fujitsu.com> <1352962777-24407-6-git-send-email-wency@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Wen Congyang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" , Andrew Morton , Yasuaki Ishimatsu , Lai Jiangshan , Jiang Liu , KOSAKI Motohiro , Minchan Kim , Mel Gorman , Konrad Rzeszutek Wilk , Toshi Kani , Jiang Liu , Benjamin Herrenschmidt , Paul Mackerras , Christoph Lameter On Thu, 15 Nov 2012, Wen Congyang wrote: > We eject the memory device even if it is in use. It is very dangerous, > and it will cause the kernel to be panicked. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Yasuaki Ishimatsu > CC: Rafael J. Wysocki > CC: Konrad Rzeszutek Wilk > Signed-off-by: Wen Congyang Acked-by: David Rientjes Thanks for adding the comment about why num_enabled is incremented for -EEXIST. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org