From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526Ab2KSVkk (ORCPT ); Mon, 19 Nov 2012 16:40:40 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:51203 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062Ab2KSVkj (ORCPT ); Mon, 19 Nov 2012 16:40:39 -0500 Date: Mon, 19 Nov 2012 13:40:37 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Josh Triplett cc: Linus Torvalds , Andrew Morton , Andrea Arcangeli , Naoya Horiguchi , Al Viro , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 29/58] mm: Make copy_pte_range static In-Reply-To: <1353302917-13995-30-git-send-email-josh@joshtriplett.org> Message-ID: References: <1353302917-13995-1-git-send-email-josh@joshtriplett.org> <1353302917-13995-30-git-send-email-josh@joshtriplett.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="531381512-846407968-1353361238=:12532" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --531381512-846407968-1353361238=:12532 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 18 Nov 2012, Josh Triplett wrote: > Nothing outside of mm/memory.c references copy_pte_range. > linux/huge_mm.h prototypes it, but nothing uses that prototype. Commit > 71e3aac0724ffe8918992d76acfe3aad7d8724a5 in January 2011 explicitly made > copy_pte_range non-static, but no commit ever introduced a caller for > copy_pte_range outside of mm/memory.c. Make the function static. > > This eliminates a warning from gcc (-Wmissing-prototypes) and from > Sparse (-Wdecl). > > mm/memory.c:917:5: warning: no previous prototype for ‘copy_pte_range’ [-Wmissing-prototypes] > > Signed-off-by: Josh Triplett Acked-by: David Rientjes --531381512-846407968-1353361238=:12532-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id BE0AF6B0081 for ; Mon, 19 Nov 2012 16:40:39 -0500 (EST) Received: by mail-pa0-f41.google.com with SMTP id fa10so3960252pad.14 for ; Mon, 19 Nov 2012 13:40:39 -0800 (PST) Date: Mon, 19 Nov 2012 13:40:37 -0800 (PST) From: David Rientjes Subject: Re: [PATCH 29/58] mm: Make copy_pte_range static In-Reply-To: <1353302917-13995-30-git-send-email-josh@joshtriplett.org> Message-ID: References: <1353302917-13995-1-git-send-email-josh@joshtriplett.org> <1353302917-13995-30-git-send-email-josh@joshtriplett.org> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="531381512-846407968-1353361238=:12532" Sender: owner-linux-mm@kvack.org List-ID: To: Josh Triplett Cc: Linus Torvalds , Andrew Morton , Andrea Arcangeli , Naoya Horiguchi , Al Viro , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-mm@kvack.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --531381512-846407968-1353361238=:12532 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 18 Nov 2012, Josh Triplett wrote: > Nothing outside of mm/memory.c references copy_pte_range. > linux/huge_mm.h prototypes it, but nothing uses that prototype. Commit > 71e3aac0724ffe8918992d76acfe3aad7d8724a5 in January 2011 explicitly made > copy_pte_range non-static, but no commit ever introduced a caller for > copy_pte_range outside of mm/memory.c. Make the function static. > > This eliminates a warning from gcc (-Wmissing-prototypes) and from > Sparse (-Wdecl). > > mm/memory.c:917:5: warning: no previous prototype for a??copy_pte_rangea?? [-Wmissing-prototypes] > > Signed-off-by: Josh Triplett Acked-by: David Rientjes --531381512-846407968-1353361238=:12532-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org