From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Walmsley Subject: Re: [PATCH 1/3] mtd nand : onfi need to be probed in 8 bits mode Date: Mon, 24 Dec 2012 00:29:26 +0000 (UTC) Message-ID: References: <1352199105-30215-1-git-send-email-matthieu.castet@parrot.com> <1354530053.30168.183.camel@sauron.fi.intel.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from utopia.booyaka.com ([74.50.51.50]:57141 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124Ab2LXA31 (ORCPT ); Sun, 23 Dec 2012 19:29:27 -0500 In-Reply-To: <1354530053.30168.183.camel@sauron.fi.intel.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Matthieu CASTET , Artem Bityutskiy Cc: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org Hi On Mon, 3 Dec 2012, Artem Bityutskiy wrote: > On Tue, 2012-11-06 at 11:51 +0100, Matthieu CASTET wrote: > > - NAND_CMD_READID want an address that it is not scaled on x16 device (it is always 0x20) > > - NAND_CMD_PARAM want 8 bits data > > > > Signed-off-by: Matthieu CASTET > > Pushed this one to l2-mtd.git, thanks! This patch (commit ff3206b2450499203532af2505a7f6f8413e92c0 in mainline) is causing warnings on OMAP3730 Beagle XM, OMAP3530 Beagle, and DM37xx EVM as of v3.8-rc1: [ 1.349456] ------------[ cut here ]------------ [ 1.351959] WARNING: at drivers/mtd/nand/nand_base.c:2861 nand_scan_ident+0xdb4/0xf90() [ 1.356292] Modules linked in: [ 1.357971] [] (unwind_backtrace+0x0/0xf0) from [] (warn_slowpath_common+0x4c/0x64) [ 1.363037] [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_null+0x1c/0x24) [ 1.368194] [] (warn_slowpath_null+0x1c/0x24) from [] (nand_scan_ident+0xdb4/0xf90) [ 1.373229] [] (nand_scan_ident+0xdb4/0xf90) from [] (omap_nand_probe+0x2e8/0x678) [ 1.378234] [] (omap_nand_probe+0x2e8/0x678) from [] (platform_drv_probe+0x18/0x1c) [ 1.383239] [] (platform_drv_probe+0x18/0x1c) from [] (driver_probe_device+0x84/0x224) [ 1.388458] [] (driver_probe_device+0x84/0x224) from [] (__driver_attach+0x94/0x98) [ 1.393493] [] (__driver_attach+0x94/0x98) from [] (bus_for_each_dev+0x50/0x7c) [ 1.398315] [] (bus_for_each_dev+0x50/0x7c) from [] (bus_add_driver+0xa0/0x2a0) [ 1.403198] [] (bus_add_driver+0xa0/0x2a0) from [] (driver_register+0x78/0x18c) [ 1.408020] [] (driver_register+0x78/0x18c) from [] (do_one_initcall+0x34/0x194) [ 1.412933] [] (do_one_initcall+0x34/0x194) from [] (kernel_init+0x154/0x2ec) [ 1.417724] [] (kernel_init+0x154/0x2ec) from [] (ret_from_fork+0x14/0x24) [ 1.422454] ---[ end trace 7f5c9fb048cfa61e ]--- The patch also looks bogus. The patch states that "ONFI need to be probed in 8 bits mode" (sic). But if that's so, shouldn't nand_flash_detect_onfi() just fail immediately, rather than warn? - Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from utopia.booyaka.com ([74.50.51.50]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tmvv7-0004zR-7A for linux-mtd@lists.infradead.org; Mon, 24 Dec 2012 00:29:29 +0000 Date: Mon, 24 Dec 2012 00:29:26 +0000 (UTC) From: Paul Walmsley To: Matthieu CASTET , Artem Bityutskiy Subject: Re: [PATCH 1/3] mtd nand : onfi need to be probed in 8 bits mode In-Reply-To: <1354530053.30168.183.camel@sauron.fi.intel.com> Message-ID: References: <1352199105-30215-1-git-send-email-matthieu.castet@parrot.com> <1354530053.30168.183.camel@sauron.fi.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi On Mon, 3 Dec 2012, Artem Bityutskiy wrote: > On Tue, 2012-11-06 at 11:51 +0100, Matthieu CASTET wrote: > > - NAND_CMD_READID want an address that it is not scaled on x16 device (it is always 0x20) > > - NAND_CMD_PARAM want 8 bits data > > > > Signed-off-by: Matthieu CASTET > > Pushed this one to l2-mtd.git, thanks! This patch (commit ff3206b2450499203532af2505a7f6f8413e92c0 in mainline) is causing warnings on OMAP3730 Beagle XM, OMAP3530 Beagle, and DM37xx EVM as of v3.8-rc1: [ 1.349456] ------------[ cut here ]------------ [ 1.351959] WARNING: at drivers/mtd/nand/nand_base.c:2861 nand_scan_ident+0xdb4/0xf90() [ 1.356292] Modules linked in: [ 1.357971] [] (unwind_backtrace+0x0/0xf0) from [] (warn_slowpath_common+0x4c/0x64) [ 1.363037] [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_null+0x1c/0x24) [ 1.368194] [] (warn_slowpath_null+0x1c/0x24) from [] (nand_scan_ident+0xdb4/0xf90) [ 1.373229] [] (nand_scan_ident+0xdb4/0xf90) from [] (omap_nand_probe+0x2e8/0x678) [ 1.378234] [] (omap_nand_probe+0x2e8/0x678) from [] (platform_drv_probe+0x18/0x1c) [ 1.383239] [] (platform_drv_probe+0x18/0x1c) from [] (driver_probe_device+0x84/0x224) [ 1.388458] [] (driver_probe_device+0x84/0x224) from [] (__driver_attach+0x94/0x98) [ 1.393493] [] (__driver_attach+0x94/0x98) from [] (bus_for_each_dev+0x50/0x7c) [ 1.398315] [] (bus_for_each_dev+0x50/0x7c) from [] (bus_add_driver+0xa0/0x2a0) [ 1.403198] [] (bus_add_driver+0xa0/0x2a0) from [] (driver_register+0x78/0x18c) [ 1.408020] [] (driver_register+0x78/0x18c) from [] (do_one_initcall+0x34/0x194) [ 1.412933] [] (do_one_initcall+0x34/0x194) from [] (kernel_init+0x154/0x2ec) [ 1.417724] [] (kernel_init+0x154/0x2ec) from [] (ret_from_fork+0x14/0x24) [ 1.422454] ---[ end trace 7f5c9fb048cfa61e ]--- The patch also looks bogus. The patch states that "ONFI need to be probed in 8 bits mode" (sic). But if that's so, shouldn't nand_flash_detect_onfi() just fail immediately, rather than warn? - Paul