From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Walmsley Subject: Re: [PATCH] ARM: AM33XX: Add missing .clkdm_name to clkdiv32k_ick clock Date: Tue, 26 Mar 2013 18:13:19 +0000 (UTC) Message-ID: References: <1364211443-27536-1-git-send-email-hvaibhav@ti.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from utopia.booyaka.com ([74.50.51.50]:39013 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345Ab3CZSNU (ORCPT ); Tue, 26 Mar 2013 14:13:20 -0400 In-Reply-To: <1364211443-27536-1-git-send-email-hvaibhav@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Vaibhav Hiremath Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren On Mon, 25 Mar 2013, Vaibhav Hiremath wrote: > During common-clock migration, .clkdm_name field got missed > for "clkdiv32k_ick" clock, which leaves "clk_24mhz_clkdm" > unused; so boot process will try to disable the clockdomain > even childs of this clock is enabled, which keeps child modules > in idle mode. Looks fine to me. You're planning to update the patch description, right? So should I wait until you repost it? Also you should probably trim the crash log after "[ 2.626025] LR is at clk_enable+0x30/0x3c" - Paul From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@pwsan.com (Paul Walmsley) Date: Tue, 26 Mar 2013 18:13:19 +0000 (UTC) Subject: [PATCH] ARM: AM33XX: Add missing .clkdm_name to clkdiv32k_ick clock In-Reply-To: <1364211443-27536-1-git-send-email-hvaibhav@ti.com> References: <1364211443-27536-1-git-send-email-hvaibhav@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 25 Mar 2013, Vaibhav Hiremath wrote: > During common-clock migration, .clkdm_name field got missed > for "clkdiv32k_ick" clock, which leaves "clk_24mhz_clkdm" > unused; so boot process will try to disable the clockdomain > even childs of this clock is enabled, which keeps child modules > in idle mode. Looks fine to me. You're planning to update the patch description, right? So should I wait until you repost it? Also you should probably trim the crash log after "[ 2.626025] LR is at clk_enable+0x30/0x3c" - Paul