From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cobra.newdream.net ([66.33.216.30]:36623 "EHLO cobra.newdream.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758536Ab3HISEP (ORCPT ); Fri, 9 Aug 2013 14:04:15 -0400 Date: Fri, 9 Aug 2013 11:04:15 -0700 (PDT) From: Sage Weil To: Chris Mason cc: Josef Bacik , "linux-btrfs@vger.kernel.org" Subject: Re: hang on 3.9, 3.10-rc5 In-Reply-To: <20130621004216.4477.93556@localhost.localdomain> Message-ID: References: <20130618163706.GC19183@localhost.localdomain> <20130618165952.9494.8953@localhost.localdomain> <20130621004216.4477.93556@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-btrfs-owner@vger.kernel.org List-ID: Hi Chris, On Thu, 20 Jun 2013, Chris Mason wrote: > Quoting Sage Weil (2013-06-20 17:56:19) > > On Wed, 19 Jun 2013, Sage Weil wrote: > > > Hi Chris, > > > > > > On Tue, 18 Jun 2013, Chris Mason wrote: > > > > [...] > > > > Very long way of saying I think we're one release_path short. Sage, I > > > > haven't tested this at all yet, I was hoping to trigger it first. > > > > > > > > diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c > > > > index c276ac9..c1954b3 100644 > > > > --- a/fs/btrfs/tree-log.c > > > > +++ b/fs/btrfs/tree-log.c > > > > @@ -3730,6 +3730,7 @@ next_slot: > > > > log_extents: > > > > if (fast_search) { > > > > btrfs_release_path(dst_path); > > > > + btrfs_release_path(path); > > > > ret = btrfs_log_changed_extents(trans, root, inode, dst_path); > > > > if (ret) { > > > > err = ret; > > > > > > This seems to be doing the trick. I'll keep testing overnight, but so far > > > so good! > > > > ...and it's still holding up well in QA. > > Awesome, thanks for getting the traces for us. Looks like this one has > been around since v3.7, so I'm not going to try and sneak it into the > 3.10 final. I'll have it in the next merge window and for stable. I was just pulling in the current -rc for testing and realized that this isn't upstream yet. Was this missed? Sorry I didn't check earlier. Thanks! sage