From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vh1ys-0005g3-CW for mharc-grub-devel@gnu.org; Thu, 14 Nov 2013 13:49:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vh1yj-0005eN-97 for grub-devel@gnu.org; Thu, 14 Nov 2013 13:49:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vh1yb-00058C-6i for grub-devel@gnu.org; Thu, 14 Nov 2013 13:49:21 -0500 Received: from hermes1.dur.ac.uk ([129.234.248.1]:43403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vh1ya-00054i-Tb for grub-devel@gnu.org; Thu, 14 Nov 2013 13:49:13 -0500 Received: from smtphost3.dur.ac.uk (smtphost3.dur.ac.uk [129.234.252.3]) by hermes1.dur.ac.uk (8.14.4/8.14.4) with ESMTP id rAEIn0o0008016; Thu, 14 Nov 2013 18:49:04 GMT Received: from procyon.dur.ac.uk (procyon.dur.ac.uk [129.234.250.129]) by smtphost3.dur.ac.uk (8.14.4/8.14.4) with ESMTP id rAEImsEf006542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Nov 2013 18:48:54 GMT Received: from procyon.dur.ac.uk (localhost [127.0.0.1]) by procyon.dur.ac.uk (8.14.3/8.11.1) with ESMTP id rAEImss1006816; Thu, 14 Nov 2013 18:48:54 GMT Received: from localhost (dcl0may@localhost) by procyon.dur.ac.uk (8.14.3/8.14.3/Submit) with ESMTP id rAEImsFa006812; Thu, 14 Nov 2013 18:48:54 GMT Date: Thu, 14 Nov 2013 18:48:54 +0000 (GMT) From: M A Young To: "=?ISO-8859-7?Q?Vladimir_'=F6-coder=2Fphcoder'_Serbinenko?=" Subject: Re: [Xen-devel] pvgrub2 is merged In-Reply-To: <52850918.1040406@gmail.com> Message-ID: References: <527EA084.6000706@gmail.com> <20131110084753.540b0107@opensuse.site> <5283DD8F.5080103@gmail.com> <52850918.1040406@gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1551057922-1384454934=:28334" X-DurhamAcUk-MailScanner: Found to be clean, Found to be clean X-DurhamAcUk-MailScanner-ID: rAEIn0o0008016 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 129.234.248.1 Cc: The development of GNU GRUB , "xen-devel@lists.xen.org" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 18:49:29 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1551057922-1384454934=:28334 Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by hermes1.dur.ac.uk id rAEIn0o0008016 On Thu, 14 Nov 2013, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > On 14.11.2013 18:03, M A Young wrote: >> >> >> On Thu, 14 Nov 2013, M A Young wrote: >> >>> On Wed, 13 Nov 2013, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote= : >>> >>>> On 13.11.2013 20:06, M A Young wrote: >>>>> It doesn't seem to understand sub-partitions. I can get it to work = if >>>>> the boot files are in /dev/xvda but not in /dev/xvda1 . >>>>> >>>> insmod part_msdos >>>> insmod part_gpt >>> >>> Right, if I add those to the embedded grub.cfg file I get to the >>> standard grub menu and the boot starts. However the boot doesn't get >>> very far - it loads the kernel and the initrd file and starts the >>> kernel but the kernel doesn't see the virtual disks so it doesn't get >>> very far. >> >> Using xenstore-ls from the dom0 on the guest when the boot stops the >> local/domain/2/device/vbd/51712 section looks like >> backend =3D "/local/domain/0/backend/vbd/2/51712" >> backend-id =3D "0" >> state =3D "6\000" >> virtual-device =3D "51712" >> device-type =3D "disk" >> ring-ref =3D "\000" >> event-channel =3D "\000" >> protocol =3D "x86_64-abi\000" >> >> As nothing else has null character endings I suspend that is wrong. >> > Good catch. Could you test following: > diff --git a/grub-core/kern/xen/init.c b/grub-core/kern/xen/init.c > index 3bfd99f..ab74543 100644 > --- a/grub-core/kern/xen/init.c > +++ b/grub-core/kern/xen/init.c > @@ -256,11 +256,10 @@ grub_xenstore_write_file (const char *dir, const = void *buf, grub_size_t len) > > grub_memset (&msg, 0, sizeof (msg)); > msg.type =3D XS_WRITE; > - msg.len =3D dirlen + len + 1; > + msg.len =3D dirlen + len; > grub_xen_store_send (&msg, sizeof (msg)); > grub_xen_store_send (dir, dirlen); > grub_xen_store_send (buf, len); > - grub_xen_store_send ("", 1); > grub_xen_store_recv (&msg, sizeof (msg)); > resp =3D grub_malloc (msg.len + 1); > if (!resp) The section is tidied up, ie. backend =3D "/local/domain/0/backend/vbd/4/51712" backend-id =3D "0" state =3D "6" virtual-device =3D "51712" device-type =3D "disk" ring-ref =3D "" event-channel =3D "" protocol =3D "x86_64-abi" but unfortunately it doesn't help as the boot process sticks at the same=20 point. I notice this section is in state 6 which apparently is "closed".=20 I wonder if the kernel expecting something else. Michael Young --8323329-1551057922-1384454934=:28334--