All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Krefting <peter@softwolves.pp.se>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: Odd broken "--date=now" behavior in current git
Date: Wed, 15 Apr 2015 08:07:35 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.00.1504150803370.8606@ds9.cixit.se> (raw)
In-Reply-To: <CA+55aFxvcN8Dz-t6fi6etycg+AiyR0crXv5AcfCdv8ji-iNBpw@mail.gmail.com>

Linus Torvalds:

> I can't be the only one seeing this? My guess is that there's a 
> missing initialization of tm.tm_isdst somewhere or whatever.

I can confirm it if I enable DST on my machine (I usually run my 
machines on CET all-year, to avoid these kind of issues):

   $ echo $TZ
   Europe/Oslo
   $ git commit -m b
   [master dee7ec1] b
    1 file changed, 1 insertion(+)
    create mode 100644 b.txt
   $ git show --pretty=fuller
   commit dee7ec1cda74a8abd7f26c60ee1e83f73bb31194 (HEAD -> master)
   Author:     Peter Krefting <peter.krefting@bridgetech.tv>
   AuthorDate: 2015-04-15 09:04:34 +0200
   Commit:     Peter Krefting <peter.krefting@bridgetech.tv>
   CommitDate: 2015-04-15 09:04:34 +0200
   [...]
   $ git commit --amend --date=now
   [...]
   $ git show --pretty=fuller
   commit b4561e5a077de7bbcaf9fc06350ea24407adcec0 (HEAD -> master)
   Author:     Peter Krefting <peter.krefting@bridgetech.tv>
   AuthorDate: 2015-04-15 08:05:04 +0100
   Commit:     Peter Krefting <peter.krefting@bridgetech.tv>
   CommitDate: 2015-04-15 09:05:04 +0200

So the datetime is correct, it's just the timezone that is wrong 
(08:05+0100 = 09:05+0200).

   $ git --version
   git version 2.4.0.rc1

-- 
\\// Peter - http://www.softwolves.pp.se/

      parent reply	other threads:[~2015-04-15  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15  4:18 Odd broken "--date=now" behavior in current git Linus Torvalds
2015-04-15  4:47 ` Junio C Hamano
2015-04-15  7:22   ` Eric Sunshine
2015-04-15 14:42     ` Junio C Hamano
2015-04-15 16:21       ` [PATCH 1/2] parse_date_basic(): return early when given a bogus timestamp Junio C Hamano
2015-04-15 16:24       ` [PATCH 2/2] parse_date_basic(): let the system handle DST conversion Junio C Hamano
2015-04-15 17:23         ` Eric Sunshine
2015-04-15 16:20     ` Odd broken "--date=now" behavior in current git Linus Torvalds
2015-04-15 17:04       ` Junio C Hamano
2015-04-15  7:07 ` Peter Krefting [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1504150803370.8606@ds9.cixit.se \
    --to=peter@softwolves.pp.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.