From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689AbdJTUtI (ORCPT ); Fri, 20 Oct 2017 16:49:08 -0400 Received: from 20pmail.ess.barracuda.com ([64.235.150.246]:40293 "EHLO 20pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbdJTUtG (ORCPT ); Fri, 20 Oct 2017 16:49:06 -0400 Date: Fri, 20 Oct 2017 21:47:51 +0100 From: "Maciej W. Rozycki" To: Aleksandar Markovic CC: , Dragan Cecavac , Aleksandar Markovic , Douglas Leung , Goran Ferenc , James Hogan , James Hogan , , "Maciej W. Rozycki" , Miodrag Dinic , Paul Burton , Paul Burton , Petar Jovanovic , Raghu Gandham , "Ralf Baechle" Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo In-Reply-To: <1508509203-30661-1-git-send-email-aleksandar.markovic@rt-rk.com> Message-ID: References: <1508509203-30661-1-git-send-email-aleksandar.markovic@rt-rk.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-BESS-ID: 1508532486-298555-4759-168240-15 X-BESS-VER: 2017.12-r1710102214 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.186156 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Oct 2017, Aleksandar Markovic wrote: > Remove unnecessary space from FPU info segment of /proc/cpuinfo. NAK. As I recall back in Nov 2001 I placed the extra space there to visually separate the CPU part from the FPU part, e.g.: cpu model : R3000A V3.0 FPU V4.0 cpu model : SiByte SB1 V0.2 FPU V0.2 etc. And the motivation behind it still stands. Please remember that /proc/cpuinfo is there for live humans to parse and grouping all these pieces together would make it harder. Which means your change adds no value I'm afraid. NB regrettably back in those days much of the patch traffic happened off any mailing list, however I have quickly tracked down my archival copy of the original submission of the change introducing this piece of code and I'll be happy to share it with anyone upon request. Maciej From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 20pmail.ess.barracuda.com ([64.235.150.246]:40457 "EHLO 20pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992181AbdJTUtFup5ML (ORCPT ); Fri, 20 Oct 2017 22:49:05 +0200 Date: Fri, 20 Oct 2017 21:47:51 +0100 From: "Maciej W. Rozycki" Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo In-Reply-To: <1508509203-30661-1-git-send-email-aleksandar.markovic@rt-rk.com> Message-ID: References: <1508509203-30661-1-git-send-email-aleksandar.markovic@rt-rk.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Aleksandar Markovic Cc: linux-mips@linux-mips.org, Dragan Cecavac , Aleksandar Markovic , Douglas Leung , Goran Ferenc , James Hogan , James Hogan , linux-kernel@vger.kernel.org, "Maciej W. Rozycki" , Miodrag Dinic , Paul Burton , Paul Burton , Petar Jovanovic , Raghu Gandham , Ralf Baechle Message-ID: <20171020204751.rgZggcaKnm6kvCYFpLzIHCXTIqb4j4iKjYiUrRfaEW0@z> On Fri, 20 Oct 2017, Aleksandar Markovic wrote: > Remove unnecessary space from FPU info segment of /proc/cpuinfo. NAK. As I recall back in Nov 2001 I placed the extra space there to visually separate the CPU part from the FPU part, e.g.: cpu model : R3000A V3.0 FPU V4.0 cpu model : SiByte SB1 V0.2 FPU V0.2 etc. And the motivation behind it still stands. Please remember that /proc/cpuinfo is there for live humans to parse and grouping all these pieces together would make it harder. Which means your change adds no value I'm afraid. NB regrettably back in those days much of the patch traffic happened off any mailing list, however I have quickly tracked down my archival copy of the original submission of the change introducing this piece of code and I'll be happy to share it with anyone upon request. Maciej