From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147AbdJTWIR (ORCPT ); Fri, 20 Oct 2017 18:08:17 -0400 Received: from 20pmail.ess.barracuda.com ([64.235.154.232]:37704 "EHLO 20pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbdJTWIQ (ORCPT ); Fri, 20 Oct 2017 18:08:16 -0400 X-Greylist: delayed 4687 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 Oct 2017 18:07:23 EDT Date: Fri, 20 Oct 2017 22:46:44 +0100 From: "Maciej W. Rozycki" To: Joe Perches CC: Aleksandar Markovic , , Dragan Cecavac , Aleksandar Markovic , Douglas Leung , Goran Ferenc , James Hogan , James Hogan , , "Maciej W. Rozycki" , Miodrag Dinic , Paul Burton , Paul Burton , Petar Jovanovic , Raghu Gandham , Ralf Baechle Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo In-Reply-To: <1508533736.30181.7.camel@perches.com> Message-ID: References: <1508509203-30661-1-git-send-email-aleksandar.markovic@rt-rk.com> <1508512648.30181.1.camel@perches.com> <1508533736.30181.7.camel@perches.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-BESS-ID: 1508537230-321458-26660-10569-1 X-BESS-VER: 2017.12-r1709122024 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.186158 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Oct 2017, Joe Perches wrote: > > > That's somewhat unpleasant code as it formats a fmt string > > > and the compiler can not verify fmt and args. > > > > > > Perhaps something like the below is preferable: > > > > Hmm, what problem exactly are you trying to solve with code that has > > worked just fine for 16 years now? > > The compiler cannot verify fmt and args. You have stated that already. Why is that a problem? Maciej From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 20pmail.ess.barracuda.com ([64.235.154.232]:40090 "EHLO 20pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990406AbdJTWIPjEuCX (ORCPT ); Sat, 21 Oct 2017 00:08:15 +0200 Date: Fri, 20 Oct 2017 22:46:44 +0100 From: "Maciej W. Rozycki" Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo In-Reply-To: <1508533736.30181.7.camel@perches.com> Message-ID: References: <1508509203-30661-1-git-send-email-aleksandar.markovic@rt-rk.com> <1508512648.30181.1.camel@perches.com> <1508533736.30181.7.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Joe Perches Cc: Aleksandar Markovic , linux-mips@linux-mips.org, Dragan Cecavac , Aleksandar Markovic , Douglas Leung , Goran Ferenc , James Hogan , James Hogan , linux-kernel@vger.kernel.org, "Maciej W. Rozycki" , Miodrag Dinic , Paul Burton , Paul Burton , Petar Jovanovic , Raghu Gandham , Ralf Baechle Message-ID: <20171020214644.gMLzszGSP09nMKIaZW4MZPyGyyYMUjTRCSpN0vEr1Bg@z> On Fri, 20 Oct 2017, Joe Perches wrote: > > > That's somewhat unpleasant code as it formats a fmt string > > > and the compiler can not verify fmt and args. > > > > > > Perhaps something like the below is preferable: > > > > Hmm, what problem exactly are you trying to solve with code that has > > worked just fine for 16 years now? > > The compiler cannot verify fmt and args. You have stated that already. Why is that a problem? Maciej