All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: reasonable for a Kconfig variable to be tested only for "_MODULE"?
Date: Thu, 12 Apr 2012 07:30:42 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1204120725070.17806@oneiric> (raw)


  playing with my cleanup scripts this morning and ran across this
output looking for unused CONFIG_ variables under drivers/ata:

$ ../s/find_unused_configs.sh drivers/ata
===== PATA_QDI
drivers/ata/Kconfig:831:config PATA_QDI
===== PATA_WINBOND_VLB
drivers/ata/Kconfig:865:config PATA_WINBOND_VLB
$

  normally, i would flag that as "variables that are defined in a
Kconfig file but are never tested anywhere", but upon further
examination:

$ $ grep -r PATA_QDI *
drivers/ata/Kconfig:config PATA_QDI
drivers/ata/pata_legacy.c:#ifdef CONFIG_PATA_QDI_MODULE
$

so "CONFIG_PATA_QDI" isn't tested, but "CONFIG_PATA_QDI_MODULE" *is*,
which is not something i'd considered.  the Kconfig entry:

config PATA_QDI
        tristate "QDI VLB PATA support"
        depends on ISA
        select PATA_LEGACY
        help
          Support for QDI 6500 and 6580 PATA controllers on VESA local bus.

and the relevant source:

/* Set to probe QDI controllers */
#ifdef CONFIG_PATA_QDI_MODULE
static int qdi = 1;
#else
static int qdi;
#endif

  is that combination reasonable?  to test *only* for
"CONFIG_whatever_MODULE"?  if it is, i'll add that check to avoid
reporting false positives.

  all of the above can be said for PATA_WINBOND_VLB as well.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================



             reply	other threads:[~2012-04-12 11:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 11:30 Robert P. J. Day [this message]
2012-04-15 20:07 ` reasonable for a Kconfig variable to be tested only for "_MODULE"? Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1204120725070.17806@oneiric \
    --to=rpjday@crashcourse.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.