From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 1/4] QMP, Introduce set-global-dirty-log command. Date: Tue, 17 Jul 2012 18:58:25 +0100 Message-ID: References: <1342531805-29894-1-git-send-email-anthony.perard@citrix.com> <1342531805-29894-2-git-send-email-anthony.perard@citrix.com> <50056F99.6090603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50056F99.6090603@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Avi Kivity Cc: Anthony Liguori , Stefano Stabellini , QEMU-devel , Luiz Capitulino , Anthony Perard , Xen Devel List-Id: xen-devel@lists.xenproject.org On Tue, 17 Jul 2012, Avi Kivity wrote: > On 07/17/2012 04:30 PM, Anthony PERARD wrote: > > This command is used during a migration of a guest under Xen. It calls > > memory_global_dirty_log_start or memory_global_dirty_log_stop according to the > > argument pass to the command. > > Is the command truly needed? Can't it come from the xen library you > link to? I thought that a while ago we decided to use QMP rather than xenstore to issue Xen commands to QEMU. The only xenstore stuff left are the PV protocols and few parameters. Of course we could use xenstore to issue commands again, but it goes against the last year and an half of development :-)