From: Julia Lawall <julia.lawall@lip6.fr>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Julia Lawall <julia@diku.dk>,
linux-kernel@vger.kernel.org, cocci@diku.dk,
Michal Marek <mmarek@suse.cz>
Subject: Re: [Cocci] [PATCH] scripts/coccinelle: ptr_ret: Add ternary operator version
Date: Tue, 21 Aug 2012 11:06:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1208211105300.1984@hadrien> (raw)
In-Reply-To: <1345538998-24600-1-git-send-email-lars@metafoo.de>
On Tue, 21 Aug 2012, Lars-Peter Clausen wrote:
> Add a ternary operator version of the open-coded PTR_RET().
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> scripts/coccinelle/api/ptr_ret.cocci | 26 ++++++++++++++++++++++++++
> 1 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci
> index cbfd08c..15f076f 100644
> --- a/scripts/coccinelle/api/ptr_ret.cocci
> +++ b/scripts/coccinelle/api/ptr_ret.cocci
> @@ -30,6 +30,13 @@ expression ptr;
> - if (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;
> + return PTR_RET(ptr);
>
> +@depends on patch@
> +expression ptr;
> +@@
> +
> +- (IS_ERR(ptr) ? PTR_ERR(ptr) : 0)
> ++ PTR_RET(ptr)
> +
> @r1 depends on !patch@
> expression ptr;
> position p1;
> @@ -44,6 +51,13 @@ position p2;
>
> * if@p2 (IS_ERR(ptr)) return PTR_ERR(ptr); return 0;
>
> +@r3 depends on !patch@
> +expression ptr;
> +position p3;
> +@@
> +
> +* IS_ERR@p3(ptr) ? PTR_ERR(ptr) : 0
> +
> @script:python depends on org@
> p << r1.p1;
> @@
> @@ -57,6 +71,12 @@ p << r2.p2;
>
> coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
>
> +@script:python depends on org@
> +p << r3.p3;
> +@@
> +
> +coccilib.org.print_todo(p[0], "WARNING: PTR_RET can be used")
> +
> @script:python depends on report@
> p << r1.p1;
> @@
> @@ -68,3 +88,9 @@ p << r2.p2;
> @@
>
> coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
> +
> +@script:python depends on report@
> +p << r3.p3;
> +@@
> +
> +coccilib.report.print_report(p[0], "WARNING: PTR_RET can be used")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> --
> 1.7.2.5
>
> _______________________________________________
> Cocci mailing list
> Cocci@diku.dk
> http://lists.diku.dk/mailman/listinfo/cocci
> (Web access from inside DIKUs LAN only)
>
next prev parent reply other threads:[~2012-08-21 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 8:49 [PATCH] scripts/coccinelle: ptr_ret: Add ternary operator version Lars-Peter Clausen
2012-08-21 9:06 ` Julia Lawall [this message]
2012-08-31 14:55 ` [Cocci] " Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1208211105300.1984@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@diku.dk \
--cc=julia@diku.dk \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.