From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60937)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1TPFyX-0007Se-Ub
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 13:03:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1TPFyW-0005w1-Uc
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 13:03:09 -0400
Received: from smtp.eu.citrix.com ([62.200.22.115]:39765)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1TPFyW-0005uT-OL
	for qemu-devel@nongnu.org; Fri, 19 Oct 2012 13:03:08 -0400
Date: Fri, 19 Oct 2012 18:02:40 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
In-Reply-To: <1350480554-23281-8-git-send-email-kraxel@redhat.com>
Message-ID: <alpine.DEB.2.02.1210191757380.2689@kaball.uk.xensource.com>
References: <1350480554-23281-1-git-send-email-kraxel@redhat.com>
	<1350480554-23281-8-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Subject: Re: [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha
 fields for 32bpp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Wed, 17 Oct 2012, Gerd Hoffmann wrote:
> Currently it is inconstent, PixelFormat->amask is left unset whereas
> abits and amax and ashift are filled.  As an alpha channel doesn't make
> sense for the vga framebuffer leave all alpha fields clear.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Actually the alpha mask was left to 0 on purpose to ignore it.
At the same time we set amax, ashift and abits to signal the presence of
an alpha byte in the pixel format.


>  console.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/console.c b/console.c
> index 48d88e4..d28b75e 100644
> --- a/console.c
> +++ b/console.c
> @@ -1715,18 +1715,15 @@ PixelFormat qemu_default_pixelformat(int bpp)
>              pf.rmask = 0x00FF0000;
>              pf.gmask = 0x0000FF00;
>              pf.bmask = 0x000000FF;
> -            pf.amax = 255;
>              pf.rmax = 255;
>              pf.gmax = 255;
>              pf.bmax = 255;
> -            pf.ashift = 24;
>              pf.rshift = 16;
>              pf.gshift = 8;
>              pf.bshift = 0;
>              pf.rbits = 8;
>              pf.gbits = 8;
>              pf.bbits = 8;
> -            pf.abits = 8;
>              break;
>          default:
>              break;
> -- 
> 1.7.1
> 
>