From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] tools/libxl: Disable useless empty floppy
 drive with qemu-xen
Date: Fri, 8 Feb 2013 12:39:14 +0000
Message-ID: <alpine.DEB.2.02.1302081239010.4275@kaball.uk.xensource.com>
References: <5111301B.8080304@heliman.it>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5111301B.8080304@heliman.it>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Fabio Fantoni <fabio.fantoni@heliman.it>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 5 Feb 2013, Fabio Fantoni wrote:
> tools/libxl: Disable useless empty floppy drive with
>   qemu-xen
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>


>   tools/libxl/libxl_dm.c |    3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 51f9914..c265618 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -406,6 +406,9 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>       if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>           int ioemu_nics = 0;
> 
> +        /* Disable useless empty floppy drive */
> +        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
> +
>           if (b_info->u.hvm.serial) {
>               flexarray_vappend(dm_args, "-serial", 
> b_info->u.hvm.serial, NULL);
>           }
> -- 
> 1.7.9.5
> 
>