From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 02/20] PVH xen: add
 XENMEM_add_to_physmap_range
Date: Thu, 16 May 2013 16:04:31 +0100
Message-ID: <alpine.DEB.2.02.1305161559430.4799@kaball.uk.xensource.com>
References: <1368579168-30829-1-git-send-email-mukesh.rathor@oracle.com>
	<1368579168-30829-3-git-send-email-mukesh.rathor@oracle.com>
	<5193787302000078000D659C@nat28.tlf.novell.com>
	<20130515160500.337cd014@mantra.us.oracle.com>
	<5194A50C02000078000D6A14@nat28.tlf.novell.com>
	<alpine.DEB.2.02.1305161159110.4799@kaball.uk.xensource.com>
	<5194E6C702000078000D6B32@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5194E6C702000078000D6B32@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 16 May 2013, Jan Beulich wrote:
> >>> On 16.05.13 at 13:03, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
> > On Thu, 16 May 2013, Jan Beulich wrote:
> >> >>> On 16.05.13 at 01:05, Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> >> >+        xatp.space = xatpr->space;
> >> >+        xatp.idx = idx;
> >> >+        xatp.gpfn = gpfn;
> >> >+        rc = xenmem_add_to_physmap_once(d, &xatp, xatpr->foreign_domid);
> >> 
> >> xatp has a domid field - why don't you use that instead of adding a
> >> new function parameter? I'm unclear anyway why two domain IDs
> >> are useful here at all - Ian, Stefano, for one I still can't spot any use
> >> of xen_add_to_physmap_range in tools and qemu (and hence can't
> >> see a clear use case), and then I doubt there's real use for one
> >> domain mapping GFNs from a second domain into a third one. If it's
> >> really dead code that got added here, shouldn't we drop it now
> >> rather than releasing 4.3 with it baked into the interface?
> > 
> > We use XENMEM_add_to_physmap_range to map foreign mfns in dom0 during
> > domain creation.
> 
> Hmm - for one, where is that code?

arch/arm/xen/enlighten.c:map_foreign_page


> And then - this involves only
> two domains, but the interface explicitly permits for three, and
> that aspect was what my query was about.
 
We are using two domains: DOMID_SELF and the foreign_domid. I take that
your point is that given that we are always using domid = DOMID_SELF,
that field is not actually useful? I guess that is correct however I
wouldn't go as far as changing that interface again only for that.