From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhg8s-0006nC-P8 for qemu-devel@nongnu.org; Wed, 29 May 2013 09:10:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhg8r-0000fZ-CN for qemu-devel@nongnu.org; Wed, 29 May 2013 09:10:14 -0400 Date: Wed, 29 May 2013 14:09:53 +0100 From: Stefano Stabellini In-Reply-To: <51A5F4BF.90504@redhat.com> Message-ID: References: <1369827271-20921-3-git-send-email-stefano.stabellini@eu.citrix.com> <51A5F06A.4040109@suse.de> <51A5F4BF.90504@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1342847746-1129964588-1369832993=:4799" Subject: Re: [Qemu-devel] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel@nongnu.org, qemu-stable@nongnu.org, anthony.perard@citrix.com, imammedo@redhat.com, =?UTF-8?Q?Andreas_F=C3=A4rber?= --1342847746-1129964588-1369832993=:4799 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 29 May 2013, Paolo Bonzini wrote: > Il 29/05/2013 14:11, Andreas F=C3=A4rber ha scritto: > >> xen_machine_pv uses cpu_x86_init, therefore it has been broken. > >> > >> This patch fixes the problem by removing the dummy CPU creation > >> altogether from xen_init_pv, relying on the fact that QEMU can now cop= e > >> with a machine without an emulated CPU. > >> > >> This fix should be backported to QEMU 1.5. > >> > >> Signed-off-by: Stefano Stabellini > >> CC: imammedo@redhat.com > >> CC: qemu-stable@nongnu.org > >=20 > > Change looks okay, > >=20 > > Reviewed-by: Andreas F=C3=A4rber > >=20 > > But for the future please avoid "this patch" in the commit message > > (because later on it's a "commit", not a patch) and also please put > > additional notices such as for backporting below the --- line. >=20 > I read it as a warning to backporters that the patch, even though it may > apply, was not tested and may even be wrong in 1.4. Yes, that's right. In any case Andreas has a point about moving notes about backports or patch revision changes under the --- line, I just have to find a way to make it work with guilt (that would also cut those notes from the commit messages therefore when I generate the patches they would go missing). --1342847746-1129964588-1369832993=:4799-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init Date: Wed, 29 May 2013 14:09:53 +0100 Message-ID: References: <1369827271-20921-3-git-send-email-stefano.stabellini@eu.citrix.com> <51A5F06A.4040109@suse.de> <51A5F4BF.90504@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1342847746-1129964588-1369832993=:4799" Return-path: In-Reply-To: <51A5F4BF.90504@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Paolo Bonzini Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel@nongnu.org, qemu-stable@nongnu.org, anthony.perard@citrix.com, imammedo@redhat.com, =?UTF-8?Q?Andreas_F=C3=A4rber?= List-Id: xen-devel@lists.xenproject.org --1342847746-1129964588-1369832993=:4799 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 29 May 2013, Paolo Bonzini wrote: > Il 29/05/2013 14:11, Andreas F=C3=A4rber ha scritto: > >> xen_machine_pv uses cpu_x86_init, therefore it has been broken. > >> > >> This patch fixes the problem by removing the dummy CPU creation > >> altogether from xen_init_pv, relying on the fact that QEMU can now cop= e > >> with a machine without an emulated CPU. > >> > >> This fix should be backported to QEMU 1.5. > >> > >> Signed-off-by: Stefano Stabellini > >> CC: imammedo@redhat.com > >> CC: qemu-stable@nongnu.org > >=20 > > Change looks okay, > >=20 > > Reviewed-by: Andreas F=C3=A4rber > >=20 > > But for the future please avoid "this patch" in the commit message > > (because later on it's a "commit", not a patch) and also please put > > additional notices such as for backporting below the --- line. >=20 > I read it as a warning to backporters that the patch, even though it may > apply, was not tested and may even be wrong in 1.4. Yes, that's right. In any case Andreas has a point about moving notes about backports or patch revision changes under the --- line, I just have to find a way to make it work with guilt (that would also cut those notes from the commit messages therefore when I generate the patches they would go missing). --1342847746-1129964588-1369832993=:4799--