From: Joe Lawrence <joe.lawrence@stratus.com>
To: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>, NeilBrown <neilb@suse.de>,
Joe Lawrence <joe.lawrence@stratus.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Dan Williams <dan.j.williams@gmail.com>,
linux-raid <linux-raid@vger.kernel.org>
Subject: Re: RAID-10 keeps aborting
Date: Wed, 12 Jun 2013 06:22:54 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1306120616420.8980@jlaw-desktop.mno.stratus.com> (raw)
In-Reply-To: <51B8153D.1040708@itwm.fraunhofer.de>
On Wed, 12 Jun 2013, Bernd Schubert wrote:
> On 06/12/2013 06:07 AM, H. Peter Anvin wrote:
> > On 06/11/2013 08:15 PM, NeilBrown wrote:
> >> If a drive reports that WRITE SAME works, but it doesn't, then I'm
> >> not sure that I can be happy about working with that drive.
> >
> > Seriously... we have that kind of problems all over the place with all
> > kinds of hardware. Falling back is sensible... the problem here is
> > *where* that needs to happen... the block layer already does, apparently.
> >
> >> If a drive has some quirky behaviour wrt WRITE SAME, then that
> >> should be handled in some place where 'quirks' are handled -
> >> certainly not in md.
> >
> > The problem here is that you don't find out ahead of time.
> >
> > Now, if I understand the issue at hand correctly is that the reporting
> > here was actually a Linux bug related to SATA drives behind a SAS
> > controller. Martin, am I right?
>
> Martin, please correct me if I'm wrong, but I think the code
> optimistically enabled WRITE_SAME for any drive, except of those on a
> sata (libata) controller. So not the drive reported that it can do
> WRITE_SAME, but scsi-midlayer did that. Martins patch should improve
> that (I still need to test it on our hardware), but I'm not sure if
> there won't be some hardware falling through.
I'm worried about other unsupported HW, too. Last night I started writing
a patch to set the raid1,10 max write same sectors to 0 for inclusion in
3.10 + stable... I'd like to include a mention of Martin's patch/the SATA
drives in the commit log. Thanks so much for hunting this down.
-- Joe
next prev parent reply other threads:[~2013-06-12 10:22 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 3:57 RAID-10 keeps aborting H. Peter Anvin
2013-06-03 4:05 ` H. Peter Anvin
2013-06-03 5:47 ` Dan Williams
2013-06-03 6:06 ` H. Peter Anvin
2013-06-03 6:14 ` Dan Williams
2013-06-03 6:30 ` H. Peter Anvin
2013-06-03 14:39 ` H. Peter Anvin
2013-06-11 16:47 ` Joe Lawrence
2013-06-11 17:12 ` H. Peter Anvin
2013-06-03 15:47 ` H. Peter Anvin
2013-06-03 16:09 ` Joe Lawrence
2013-06-03 17:22 ` Dan Williams
2013-06-03 17:40 ` H. Peter Anvin
2013-06-03 18:35 ` Martin K. Petersen
2013-06-03 18:38 ` H. Peter Anvin
2013-06-03 18:40 ` H. Peter Anvin
2013-06-03 22:20 ` H. Peter Anvin
2013-06-03 22:34 ` H. Peter Anvin
2013-06-04 15:56 ` Martin K. Petersen
2013-06-03 23:19 ` H. Peter Anvin
2013-06-04 15:39 ` Joe Lawrence
2013-06-04 15:46 ` H. Peter Anvin
2013-06-04 15:54 ` Martin K. Petersen
2013-06-05 10:02 ` Bernd Schubert
2013-06-05 11:38 ` Bernd Schubert
2013-06-05 12:53 ` [PATCH] scsi: Check if the device support WRITE_SAME_10 Bernd Schubert
2013-06-05 19:14 ` Martin K. Petersen
2013-06-05 20:09 ` Bernd Schubert
2013-06-07 2:15 ` Martin K. Petersen
2013-06-12 19:34 ` Bernd Schubert
2013-06-05 19:11 ` RAID-10 keeps aborting Martin K. Petersen
2013-06-04 17:36 ` Dan Williams
2013-06-04 17:54 ` Martin K. Petersen
2013-06-04 17:57 ` H. Peter Anvin
2013-06-04 18:04 ` Martin K. Petersen
2013-06-04 18:32 ` Dan Williams
2013-06-04 18:38 ` H. Peter Anvin
2013-06-04 18:56 ` Dan Williams
2013-06-05 2:39 ` H. Peter Anvin
[not found] ` <(H.>
[not found] ` <Peter>
[not found] ` <Anvin's>
[not found] ` <message>
[not found] ` <of>
[not found] ` <"Mon>
[not found] ` <13>
[not found] ` <"Wed>
[not found] ` <12>
[not found] ` <7>
[not found] ` <Nov>
[not found] ` <2018>
[not found] ` <06:48:34>
[not found] ` <+1100")>
2018-11-07 1:52 ` linux-next: Signed-off-by missing for commit in the scsi-fixes tree Martin K. Petersen
2020-04-03 3:45 ` [PATCH 0/4] block: Add support for REQ_OP_ASSIGN_RANGE Martin K. Petersen
2020-04-07 2:27 ` Dave Chinner
2020-04-08 4:10 ` Martin K. Petersen
2020-04-19 22:36 ` Dave Chinner
2020-04-23 0:40 ` Martin K. Petersen
[not found] ` <"Tue>
[not found] ` <04>
[not found] ` <Jun>
[not found] ` <2013>
[not found] ` <14:27:47>
[not found] ` <-0400")>
2013-06-07 2:19 ` RAID-10 keeps aborting Martin K. Petersen
2013-06-10 14:15 ` Joe Lawrence
2013-06-12 3:15 ` NeilBrown
2013-06-12 4:07 ` H. Peter Anvin
2013-06-12 6:29 ` Bernd Schubert
2013-06-12 10:22 ` Joe Lawrence [this message]
2013-06-12 14:28 ` Martin K. Petersen
2013-06-12 14:25 ` Martin K. Petersen
2013-06-12 14:29 ` H. Peter Anvin
2013-06-12 14:34 ` Martin K. Petersen
2013-06-12 14:37 ` H. Peter Anvin
2013-06-12 14:45 ` H. Peter Anvin
[not found] ` <5AA430FFE4486C448003201AC83BC85E0360CE3F@EXHQ.corp.stratus! .com>
[not found] ` <5AA430FFE4486C448003201AC83BC85E0360CE3F@EXHQ.corp.stratus.com>
2013-06-12 15:58 ` H. Peter Anvin
2013-06-13 3:10 ` NeilBrown
2013-06-13 3:13 ` H. Peter Anvin
2013-06-13 3:31 ` NeilBrown
2013-06-13 21:40 ` Martin K. Petersen
2013-06-13 2:45 ` Joe Lawrence
2013-06-13 3:11 ` NeilBrown
[not found] ` <19:39:58>
[not found] ` <-0700")>
2013-06-05 19:29 ` Martin K. Petersen
2013-06-06 18:27 ` Joe Lawrence
[not found] ` <(Joe>
2013-06-06 18:36 ` H. Peter Anvin
2013-06-12 14:43 ` Martin K. Petersen
2020-04-01 2:29 ` [PATCH 0/4] block: Add support for REQ_OP_ASSIGN_RANGE Martin K. Petersen
2020-04-01 4:53 ` Chaitanya Kulkarni
2020-05-12 16:01 ` [PATCH v11 00/10] Introduce Zone Append for writing to zoned block devices Martin K. Petersen
2020-05-12 16:04 ` Christoph Hellwig
2020-05-12 16:12 ` Martin K. Petersen
2020-05-12 16:18 ` Johannes Thumshirn
2020-05-12 16:24 ` Martin K. Petersen
[not found] ` <"Sun>
[not found] ` <29>
[not found] ` <Mar>
[not found] ` <2020>
[not found] ` <20:35:11>
[not found] ` <+0800")>
2020-07-13 16:47 ` [PATCH 2/2] block: improve discard bio alignment in __blkdev_issue_discard() Martin K. Petersen
2020-07-13 17:50 ` Coly Li
[not found] ` <10:12:26>
[not found] ` <-0800")>
2020-12-01 5:19 ` [PATCH] lpfc: Correct null ndlp reference on routine exit Martin K. Petersen
[not found] ` <"Thu>
[not found] ` <3>
[not found] ` <Dec>
[not found] ` <2015>
[not found] ` <07:57:35>
[not found] ` <+0100")>
2015-12-08 1:12 ` [PATCH] scsi_dh_alua: Remove stale variables Martin K. Petersen
2020-12-09 2:17 ` [PATCH 0/2] two UFS changes Martin K. Petersen
2013-06-11 21:50 ` RAID-10 keeps aborting Joe Lawrence
2013-06-11 21:53 ` H. Peter Anvin
2015-12-03 6:57 [PATCH] scsi_dh_alua: Remove stale variables Hannes Reinecke
[not found] ` <(Hannes>
2015-12-03 9:23 ` Johannes Thumshirn
2015-12-03 16:43 ` Christoph Hellwig
2018-11-06 19:48 linux-next: Signed-off-by missing for commit in the scsi-fixes tree Stephen Rothwell
[not found] ` <(Stephen>
2020-03-29 17:47 [PATCH 0/4] block: Add support for REQ_OP_ASSIGN_RANGE Chaitanya Kulkarni
[not found] ` <(Chaitanya>
2020-03-29 17:47 ` [PATCH 1/4] block: create payloadless issue bio helper Chaitanya Kulkarni
2020-03-29 17:47 ` [PATCH 2/4] block: Add support for REQ_OP_ASSIGN_RANGE Chaitanya Kulkarni
2020-03-29 17:47 ` [PATCH 3/4] loop: Forward REQ_OP_ASSIGN_RANGE into fallocate(0) Chaitanya Kulkarni
2020-03-29 17:47 ` [PATCH 4/4] ext4: Notify block device about alloc-assigned blk Chaitanya Kulkarni
2020-04-01 6:22 ` [PATCH 0/4] block: Add support for REQ_OP_ASSIGN_RANGE Konstantin Khlebnikov
2020-04-02 2:29 ` Martin K. Petersen
2020-04-02 9:49 ` Konstantin Khlebnikov
2020-04-02 22:41 ` Dave Chinner
2020-04-03 1:34 ` Martin K. Petersen
2020-04-03 2:57 ` Dave Chinner
[not found] ` <(Dave>
2020-05-12 8:55 [PATCH v11 00/10] Introduce Zone Append for writing to zoned block devices Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 01/10] block: provide fallbacks for blk_queue_zone_is_seq and blk_queue_zone_no Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 02/10] block: rename __bio_add_pc_page to bio_add_hw_page Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 03/10] block: Introduce REQ_OP_ZONE_APPEND Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 04/10] block: introduce blk_req_zone_write_trylock Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 05/10] block: Modify revalidate zones Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 06/10] scsi: sd_zbc: factor out sanity checks for zoned commands Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 07/10] scsi: sd_zbc: emulate ZONE_APPEND commands Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 08/10] null_blk: Support REQ_OP_ZONE_APPEND Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 09/10] block: export bio_release_pages and bio_iov_iter_get_pages Johannes Thumshirn
2020-05-12 8:55 ` [PATCH v11 10/10] zonefs: use REQ_OP_ZONE_APPEND for sync DIO Johannes Thumshirn
2020-05-12 13:17 ` [PATCH v11 00/10] Introduce Zone Append for writing to zoned block devices Christoph Hellwig
[not found] ` <(Christoph>
2020-05-13 2:37 ` Jens Axboe
2020-07-13 12:35 [PATCH 0/2] two generic block layer fixes for 5.9 Coly Li
2020-07-13 12:35 ` [PATCH 1/2] block: change REQ_OP_ZONE_RESET and REQ_OP_ZONE_RESET_ALL to be odd numbers Coly Li
2020-07-13 23:12 ` Damien Le Moal
2020-07-13 12:35 ` [PATCH 2/2] block: improve discard bio alignment in __blkdev_issue_discard() Coly Li
[not found] ` <(Coly>
2020-11-30 18:12 [PATCH] lpfc: Correct null ndlp reference on routine exit James Smart
[not found] ` <(James>
2020-12-08 4:52 ` Martin K. Petersen
[not found] <CGME20201207190149epcas5p2d877f4e3f6d31548d97f9b486d243a05@epcas5p2.samsung.com>
2020-12-07 19:01 ` [PATCH 0/2] two UFS changes Bean Huo
[not found] ` <(Bean>
2020-12-07 19:01 ` [PATCH 1/2] scsi: ufs: Remove an unused macro definition POWER_DESC_MAX_SIZE Bean Huo
2020-12-08 7:52 ` Avri Altman
2020-12-07 19:01 ` [PATCH 2/2] scsi: ufs: Fix wrong print message in dev_err() Bean Huo
2020-12-08 7:53 ` Avri Altman
2020-12-08 2:57 ` [PATCH 0/2] two UFS changes Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1306120616420.8980@jlaw-desktop.mno.stratus.com \
--to=joe.lawrence@stratus.com \
--cc=bernd.schubert@itwm.fraunhofer.de \
--cc=dan.j.williams@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.