From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 5/5] x86/xen: sync the CMOS RTC as well as
 the Xen wallclock
Date: Fri, 28 Jun 2013 17:38:12 +0200 (CEST)
Message-ID: <alpine.DEB.2.02.1306281727240.4013__27684.992113109$1372434008$gmane$org@ionos.tec.linutronix.de>
References: <1372329348-20841-1-git-send-email-david.vrabel@citrix.com>
	<1372329348-20841-6-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1372329348-20841-6-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 27 Jun 2013, David Vrabel wrote:

> From: David Vrabel <david.vrabel@citrix.com>
> 
> Adjustments to Xen's persistent clock via update_persistent_clock()
> don't actually persist, as the Xen wallclock is a software only clock
> and modifications to it do not modify the underlying CMOS RTC.
> 
> The x86_platform.set_wallclock hook can be used to keep the hardware
> RTC synchronized (as on bare metal).  Because the Xen wallclock is now
> kept synchronized by pvclock_gtod notifier, xen_set_wallclock() need
> not do this and dom0 can simply use the native implementation.

I can understand that part, but ...
 
>  static int xen_pvclock_gtod_notify(struct notifier_block *nb, unsigned long was_set,
>  				   void *priv)
>  {
> +	static struct timespec next;
>  	struct timespec now;
>  	struct xen_platform_op op;
>  
> -	if (!was_set)
> -		return NOTIFY_OK;
> -
>  	now = __current_kernel_time();
>  
> +	if (!was_set && timespec_compare(&now, &next) < 0)
> +		return NOTIFY_OK;
> +
>  	op.cmd = XENPF_settime;
>  	op.u.settime.secs = now.tv_sec;
>  	op.u.settime.nsecs = now.tv_nsec;
>  	op.u.settime.system_time = xen_clocksource_read();
>  
>  	(void)HYPERVISOR_dom0_op(&op);
> +
> +	/*
> +	 * Don't update the wallclock for another 11 minutes. This is
> +	 * the same period as the sync_cmos_clock() work.
> +	 */
> +	next = now;
> +	next.tv_sec += 11*60;
> +

How is this related to the changelog? /me is confused .....