From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible Date: Mon, 19 Aug 2013 23:59:44 -0700 (PDT) Message-ID: References: <1375409725-22004-1-git-send-email-rvaswani@codeaurora.org> <1375409725-22004-3-git-send-email-rvaswani@codeaurora.org> <20130812155016.GC27165@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mail-pd0-f174.google.com ([209.85.192.174]:57154 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185Ab3HTG7r (ORCPT ); Tue, 20 Aug 2013 02:59:47 -0400 Received: by mail-pd0-f174.google.com with SMTP id y13so44248pdi.19 for ; Mon, 19 Aug 2013 23:59:47 -0700 (PDT) In-Reply-To: <20130812155016.GC27165@e106331-lin.cambridge.arm.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mark Rutland Cc: Rohit Vaswani , David Brown , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Daniel Walker , Bryan Huntsman , "grant.likely@linaro.org" , Lorenzo Pieralisi , Nicolas Pitre , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , Sudeep KarkadaNagesha On Mon, 12 Aug 2013, Mark Rutland wrote: > > static void __init msm_smp_prepare_cpus(unsigned int max_cpus) > > { > > + int cpu, map; > > + unsigned int flags = 0; > > + > > + for_each_present_cpu(cpu) { > > + map = cpu_logical_map(cpu); > > + if (map > ARRAY_SIZE(cold_boot_flags)) { > > + set_cpu_present(cpu, false); > > + __WARN(); > > + continue; > > + } > > + flags |= cold_boot_flags[map]; __WARN() can't be used in generic code because it's possible to have CONFIG_BUG=n, you probably want something like WARN_ON(1) instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407Ab3HTG7v (ORCPT ); Tue, 20 Aug 2013 02:59:51 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:40048 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196Ab3HTG7r (ORCPT ); Tue, 20 Aug 2013 02:59:47 -0400 Date: Mon, 19 Aug 2013 23:59:44 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mark Rutland cc: Rohit Vaswani , David Brown , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Daniel Walker , Bryan Huntsman , "grant.likely@linaro.org" , Lorenzo Pieralisi , Nicolas Pitre , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , Sudeep KarkadaNagesha Subject: Re: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible In-Reply-To: <20130812155016.GC27165@e106331-lin.cambridge.arm.com> Message-ID: References: <1375409725-22004-1-git-send-email-rvaswani@codeaurora.org> <1375409725-22004-3-git-send-email-rvaswani@codeaurora.org> <20130812155016.GC27165@e106331-lin.cambridge.arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Aug 2013, Mark Rutland wrote: > > static void __init msm_smp_prepare_cpus(unsigned int max_cpus) > > { > > + int cpu, map; > > + unsigned int flags = 0; > > + > > + for_each_present_cpu(cpu) { > > + map = cpu_logical_map(cpu); > > + if (map > ARRAY_SIZE(cold_boot_flags)) { > > + set_cpu_present(cpu, false); > > + __WARN(); > > + continue; > > + } > > + flags |= cold_boot_flags[map]; __WARN() can't be used in generic code because it's possible to have CONFIG_BUG=n, you probably want something like WARN_ON(1) instead. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rientjes@google.com (David Rientjes) Date: Mon, 19 Aug 2013 23:59:44 -0700 (PDT) Subject: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible In-Reply-To: <20130812155016.GC27165@e106331-lin.cambridge.arm.com> References: <1375409725-22004-1-git-send-email-rvaswani@codeaurora.org> <1375409725-22004-3-git-send-email-rvaswani@codeaurora.org> <20130812155016.GC27165@e106331-lin.cambridge.arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 12 Aug 2013, Mark Rutland wrote: > > static void __init msm_smp_prepare_cpus(unsigned int max_cpus) > > { > > + int cpu, map; > > + unsigned int flags = 0; > > + > > + for_each_present_cpu(cpu) { > > + map = cpu_logical_map(cpu); > > + if (map > ARRAY_SIZE(cold_boot_flags)) { > > + set_cpu_present(cpu, false); > > + __WARN(); > > + continue; > > + } > > + flags |= cold_boot_flags[map]; __WARN() can't be used in generic code because it's possible to have CONFIG_BUG=n, you probably want something like WARN_ON(1) instead.