From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [patch 18/26] xen: Use the proper irq functions Date: Mon, 24 Feb 2014 22:13:35 +0100 (CET) Message-ID: References: <20140223212703.511977310@linutronix.de> <20140223212738.222412125@linutronix.de> <530B5624.8080309@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WI2q9-0003nk-9A for xen-devel@lists.xenproject.org; Mon, 24 Feb 2014 21:13:29 +0000 In-Reply-To: <530B5624.8080309@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: Peter Zijlstra , Xen , Ingo Molnar , LKML List-Id: xen-devel@lists.xenproject.org On Mon, 24 Feb 2014, David Vrabel wrote: > On 23/02/14 21:40, Thomas Gleixner wrote: > > I really can't understand why people keep adding irq_desc abuse. We > > have enough proper interfaces. Delete another 14 lines of hackery. > > generic_handler_irq() already tests for !desc so use this instead > of generic_handle_irq_desc(). Use irq_get_irq_data() instead of > desc->irq_data. Fair enough. I was not really in the mood to come up with proper changelogs :) > Otherwise, > > Reviewed-by: David Vrabel > > David >