From: Thomas Gleixner <tglx@linutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
fweisbec@gmail.com, linaro-networking@linaro.org,
Arvind.Chauhan@arm.com
Subject: Re: [PATCH 00/16] timers/hrtimers: Minor cleanups: Part II
Date: Mon, 31 Mar 2014 15:38:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1403311522080.14882@ionos.tec.linutronix.de> (raw)
In-Reply-To: <cover.1396006658.git.viresh.kumar@linaro.org>
On Fri, 28 Mar 2014, Viresh Kumar wrote:
> I have got few more cleanups other than what I posted yesterday:
> https://lkml.org/lkml/2014/3/26/107
And those cleanups make the compiler generate worse code at least on
x86_64:
text data bss dec hex filename
7475 554 0 8029 1f5d kernel/hrtimer.o
7706 554 0 8260 2044 kernel/hrtimer.o
So just removing parameters and return values because you can get the
same information from a datastructure is not necessarily a good thing.
Thanks,
tglx
next prev parent reply other threads:[~2014-03-31 13:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 11:41 [PATCH 00/16] timers/hrtimers: Minor cleanups: Part II Viresh Kumar
2014-03-28 11:41 ` [PATCH 01/16] hrtimer: move unlock_hrtimer_base() upwards Viresh Kumar
2014-03-28 11:41 ` [PATCH 02/16] hrtimer: reorder code in __remove_hrtimer() Viresh Kumar
2014-04-02 5:41 ` Viresh Kumar
2014-03-28 11:41 ` [PATCH 03/16] hrtimer: Create hrtimer_get_monoexpires() Viresh Kumar
2014-03-28 11:41 ` [PATCH 04/16] hrtimer: remove 'base' parameter from remove_timer() and __remove_timer() Viresh Kumar
2014-03-28 11:41 ` [PATCH 05/16] hrtimer: remove 'base' parameter from switch_hrtimer_base() Viresh Kumar
2014-03-28 11:41 ` [PATCH 06/16] hrtimer: remove 'base' parameter from enqueue_hrtimer() Viresh Kumar
2014-03-28 11:41 ` [PATCH 07/16] hrtimer: remove 'base' parameter from hrtimer_{enqueue_}reprogram() Viresh Kumar
2014-03-28 11:41 ` [PATCH 08/16] hrtimer: make switch_hrtimer_base() return void Viresh Kumar
2014-03-28 11:41 ` [PATCH 09/16] hrtimer: make lock_hrtimer_base() " Viresh Kumar
2014-03-28 11:41 ` [PATCH 10/16] hrtimer: make enqueue_hrtimer() " Viresh Kumar
2014-03-28 11:41 ` [PATCH 11/16] hrtimer: don't check if timer is queued in __remove_hrtimer() Viresh Kumar
2014-03-28 11:41 ` [PATCH 12/16] hrtimer: rewrite switch_hrtimer_base() to remove extra indentation level Viresh Kumar
2014-03-28 11:41 ` [PATCH 13/16] hrtimer: rewrite remove_hrtimer() " Viresh Kumar
2014-03-28 11:41 ` [PATCH 14/16] hrtimer: replace base by new_base to get resolution: __hrtimer_start_range_ns() Viresh Kumar
2014-03-28 11:41 ` [PATCH 15/16] hrtimer: create base_on_this_cpu() Viresh Kumar
2014-03-28 11:41 ` [PATCH 16/16] hrtimer: use base->hres_active directly instead of hrtimer_hres_active() Viresh Kumar
2014-03-28 12:24 ` Viresh Kumar
2014-03-28 12:26 ` [PATCH V2 " Viresh Kumar
2014-03-31 13:38 ` Thomas Gleixner [this message]
2014-03-31 14:31 ` [PATCH 00/16] timers/hrtimers: Minor cleanups: Part II Viresh Kumar
2014-03-31 15:51 ` Thomas Gleixner
2014-04-01 6:33 ` Viresh Kumar
2014-04-01 7:02 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1403311522080.14882@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Arvind.Chauhan@arm.com \
--cc=fweisbec@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linaro-networking@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.